Date: Wed, 7 Jan 2015 23:46:31 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org>, Nikos Vassiliadis <nvass@gmx.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <20150107204631.GG15484@FreeBSD.org> In-Reply-To: <201501060903.t06934qp081875@svn.freebsd.org> References: <201501060903.t06934qp081875@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: C> Author: rodrigc C> Date: Tue Jan 6 09:03:03 2015 C> New Revision: 276747 C> URL: https://svnweb.freebsd.org/changeset/base/276747 C> C> Log: C> Instead of creating a purge thread for every vnet, create C> a single purge thread and clean up all vnets from this thread. C> C> PR: 194515 C> Differential Revision: D1315 C> Submitted by: Nikos Vassiliadis <nvass@gmx.com> I am not sure that this is a good idea. The core idea of VNETs is that they are isolated from each other. If we serialize purging, then vnets are strongly affecting each other. AFAIU, from the PR there is some panic fixed. What is the actual bug and why couldn't it be fixed with having per-vnet thread? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150107204631.GG15484>