Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Jun 2012 18:19:02 -0700
From:      Devin Teske <devin.teske@fisglobal.com>
To:        Clayton Milos <clay@milos.co.za>
Cc:        Devin Teske <dteske@freebsd.org>, Freebsd-stable@freebsd.org
Subject:   Re: [CFT] Need Testers for: sysutils/bsdconfig
Message-ID:  <741A1B0E-6C22-4032-9A4A-2181144430ED@fisglobal.com>
In-Reply-To: <A57ECB17-FC90-4033-BD83-1E11CF8B9A6E@fisglobal.com>
References:  <2322BE6D-24A8-4F4A-84B2-4DFE33BCA65B@fisglobal.com>	<4FE3EB9D.9070509@fuzzwad.org>	<4FE419CD.60708@rdtc.ru>	<F34D40AA-3AE4-4A1F-B521-CEC2A06ABC79@fisglobal.com>	<4FE4245C.3040806@rdtc.ru>	<90361FE2-2298-48E5-B8B6-2BA704781098@fisglobal.com> <4FE431C0.8040509@rdtc.ru> <006001cd5072$84247cd0$8c6d7670$@milos.co.za> <A57ECB17-FC90-4033-BD83-1E11CF8B9A6E@fisglobal.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jun 23, 2012, at 12:11 PM, Devin Teske wrote:

>=20
> On Jun 22, 2012, at 5:27 AM, Clayton Milos wrote:
>=20
[snip]

>> Also it said that my user add failed but it was actually added as uid 10=
05.
>=20
> I'm working on this one. I'm changing the routines to allow the UNIX pw(8=
) errors to filter through, rather than masking them with a static error on=
 non-success.
>=20

I overhauled the usermgmt module to rely entirely on pw(8). It should work =
a lot better now. I addressed all concerns in the rewrite which should be p=
ublished soon in the up-coming 0.7.3 PORTVERSION.


>=20
>> I added another user and it stated the uid 1005 when I was creating it b=
ut
>> showed 1006 in the summary screen. It also said that adding the user fai=
led.
>=20
> "pw usernext" is executed to get the next uid/gid pair that is available.=
 It's possible a user was added in the process. I've not witnessed this, bu=
t will try to replicate.
>=20

This race-condition was addressed and should no longer be possible (regardl=
ess of whether it was the root cause of the failure to add).



>=20
>> Perhaps I used to short a password as there was no password field entere=
d in
>> /etc/master.passwd
>> twat:*:1005:1005::1340540161:1340626570:twat:/home/twat:/bin/sh
>> test1:*:1006:1006::1340454020:1340496000:test1:/home/test1:/bin/tcsh
>>=20
>=20
> The password is only set (as a separate command) if the pw(8) useradd suc=
ceeded. I'm working on catching errors in edge-cases where we should procee=
d despite non-success.
>=20

This too has been enhanced.



>=20
>> When selecting user account expiry the calendar starts at 1 January 1970=
. I
>> understand that this is when Unix time started but it would be nice for =
it
>> to start from the current date.
>>=20
>=20
> I filed PR docs/169354 against the passwd(5) manual. If nobody picks up t=
he PR in a timely fashion, I'll pro-actively modify bsdconfig to follow wha=
t the man-page _should_ say versus what it _does_ say about "how to treat t=
he value of zero" (the default).

PR docs/169354 was closed after being patched by bjk@ (thx again bjk!)

The upcoming release folds this change in to coincide with the updated manu=
al.
--=20
Thanks again for testing!
Devin

P.S. Keep an eye out for the next revision of this port for more testing.

_____________
The information contained in this message is proprietary and/or confidentia=
l. If you are not the intended recipient, please: (i) delete the message an=
d all copies; (ii) do not disclose, distribute or use the message in any ma=
nner; and (iii) notify the sender immediately. In addition, please be aware=
 that any message addressed to our domain is subject to archiving and revie=
w by persons other than the intended recipient. Thank you.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?741A1B0E-6C22-4032-9A4A-2181144430ED>