Date: Wed, 15 Jun 2011 13:58:53 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: fs@FreeBSD.org Subject: Re: [CFR][ZFS] Show removed devices by GUID in zpool output. Message-ID: <20110615115853.GG1975@garage.freebsd.pl> In-Reply-To: <4DF7C406.1080903@scsiguy.com> References: <4DF7C406.1080903@scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--oXNgvKVxGWJ0RPMJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2011 at 02:26:46PM -0600, Justin T. Gibbs wrote: > The current behavior of zpool_vdev_name() is to report the vdev path > (e.g. /dev/da0) unless > a vdev has the ZPOOL_CONFIG_NOT_PRESENT attribute set. This > attribute is only set when > a vdev is not found during import/mount of a pool. The attached > patch also displays a vdev > by GUID if it cannot be opened post import or is marked removed > (e.g. via a GEOM orphan > event). >=20 > The main motivation for this change is that vdev paths are not > unique to a physical leaf vdev. > It is easy to get into a situation where you need to "detach > /dev/da0" event though da0 is > an active member of the same pool in which a "previous da0" was once > removed. With > zpool_vdev_name() reporting the GUID, the user is equipped to > provide an unambiguous > command that represents their desired action. That's a useful change. It confused users in the past. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --oXNgvKVxGWJ0RPMJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk34nn0ACgkQForvXbEpPzSAqwCgti3FTi2oxoOJPIbVwDQXUSY6 0ywAoI3aBjV9eBJGXQlc7rg8Fo2mij2t =R8cW -----END PGP SIGNATURE----- --oXNgvKVxGWJ0RPMJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110615115853.GG1975>