Date: Fri, 01 Sep 2017 12:00:09 -0500 From: Josh Paetzel <jpaetzel@FreeBSD.org> To: svn-src-all@freebsd.org Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf Message-ID: <1504285209.3899479.1092460000.413562B8@webmail.messagingengine.com> In-Reply-To: <1504284895.41612.29.camel@freebsd.org> References: <201709011554.v81FssRG083114@repo.freebsd.org> <CAG6CVpVnEejQdE-=SLyLU__PJpuFNmC03FHnnx1Vfnv=uZN20Q@mail.gmail.com> <1504284895.41612.29.camel@freebsd.org>
index | next in thread | previous in thread | raw e-mail
Ok, I'm going to revert it for now. There was a mistake in the commit, the commit message was wrong, and it sounds like we need more consensus. On Fri, Sep 1, 2017, at 11:54 AM, Ian Lepore wrote: > On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote: > > Wait, why? The PR doesn't explain it any better than this commit > > message. > > > > On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel <jpaetzel@freebsd.org> > > wrote: > > > > > > Author: jpaetzel > > > Date: Fri Sep 1 15:54:53 2017 > > > New Revision: 323087 > > > URL: https://svnweb.freebsd.org/changeset/base/323087 > > > > > > Log: > > > Take options IPSEC out of GENERIC > > > > > > PR: 220170 > > > Submitted by: delphij > > > Reviewed by: ae, glebius > > > MFC after: 2 weeks > > > Differential Revision: D11806 > > The differential revision (which should be cited using the complete url > in the commit) seems to indicate that it's because it can be kldloaded. > > This change misses the armv6 platform, where the option appears in > std.armv6, which gets included in GENERIC (and all other armv6 > configs). > > This change seems to warrant an entry in UPDATING, because it's going > to catch a lot of people by surprise. Even people with custom kernels, > if they follow the advice of the handbook and "include GENERIC" then > override things. > > -- Ian > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Thanks, Josh Paetzelhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1504285209.3899479.1092460000.413562B8>