Date: Sun, 05 Nov 2017 21:23:37 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 223440] world needs review and adjustment for the disabling of fallocate for zfs (-r325320), lld included Message-ID: <bug-223440-8-cpCjgPF63q@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-223440-8@https.bugs.freebsd.org/bugzilla/> References: <bug-223440-8@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223440 --- Comment #3 from Ed Maste <emaste@freebsd.org> --- > contrib/sqlite3/sqlite3.c > crypto/heimdal/lib/sqlite/sqlite3.c AFAICT this is the only issue that needs more effort / investigation, as it appears that it does not correctly handle EINVAL or EOPNOTSUPP: #if defined(HAVE_POSIX_FALLOCATE) && HAVE_POSIX_FALLOCATE /* The code below is handling the return value of osFallocate() ** correctly. posix_fallocate() is defined to "returns zero on success, ** or an error number on failure". See the manpage for details. */ int err; do{ err = osFallocate(pFile->h, buf.st_size, nSize-buf.st_size); }while( err==EINTR ); if( err ) return SQLITE_IOERR_WRITE; #else Other source files with posix_fallocate / fallocate do not have an issue: > contrib/netbsd-tests/lib/libc/sys/t_posix_fallocate.c It's only testing that posix_fallocate doesn't change errno, and that EBADF is returned for a bad fd (-1), so no issue here. > contrib/llvm/lib/Support/Unix/Path.inc Fixed by r325420 > contrib/pjdfstest/pjdfstest.c Appears to be test harness only; I did not find a test invoking posix_fallocate or fallocate. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-223440-8-cpCjgPF63q>