Date: Wed, 18 Sep 2002 10:32:37 -0400 From: "Dan Langille" <dan@langille.org> To: Dominic Marks <dominic_marks@btinternet.com> Cc: Peter Pentchev <roam@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/devel/gindent Makefile pkg-plist ports/devel/gindent/files patch-doc:Makefile.in Message-ID: <3D885645.23711.41D1B0FD@localhost> In-Reply-To: <20020918142950.GA34573@gallium> References: <3D88438C.16000.41888E90@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 Sep 2002 at 15:29, Dominic Marks wrote: > On Wed, Sep 18, 2002 at 09:12:44AM -0400, Dan Langille wrote: > > On 18 Sep 2002 at 5:32, Peter Pentchev wrote: > > > > > roam 2002/09/18 05:32:37 PDT > > > > > > Modified files: > > > devel/gindent Makefile pkg-plist > > > devel/gindent/files patch-doc:Makefile.in > > > Log: > > > Support CFLAGS/CXXFLAGS properly. > > > Honor NOPORTDOCS. > > > > Waking up this morning, FreshPorts tells me[1] there is a problem > > with this port: > > > > [dan@undef:~/ports/devel/gindent] $ make -V PORTVERSION > > "/usr/home/dan/ports/devel/gindent/Makefile", line 36: Malformed > > conditional (!defiend(NOPORTDOCS)) > > "/usr/home/dan/ports/devel/gindent/Makefile", line 40: if-less endif > > "/usr/home/dan/ports/devel/gindent/Makefile", line 40: Need an > > operator make: fatal errors encountered -- cannot continue > > [dan@undef:~/ports/devel/gindent] $ > > > > Here's the patch: > > > > -.if !defiend(NOPORTDOCS) > > +.if !defined(NOPORTDOCS) > > > > [1] - FreshPorts would have told roam if he was opt'd in at > > FreshPorts. FreshPorts runs a sanity test on every port commit. If > > a commiter opts in, any errors found in their commits are reported > > directly to them instead of me being the go between. I urge every > > port committer to opt in. It saves me the bother of reporting your > > errors to you and the world. It also means the problem is fixed > > much sooner. At present, we have 15 opt'd in committers, where are > > the rest of you? > > It would be nice of non-committer maintainers could also receive these > warnings, any reason why this a committer only thing ? Please join the conversation in -ports. We covered that one. See Subject: HEADS UP: all ports committers urged to opt in". -- Dan Langille I'm looking for a computer job: http://www.freebsddiary.org/dan_langille.php To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D885645.23711.41D1B0FD>