Date: Mon, 26 Apr 2021 09:51:56 -0700
From: Neel Chauhan <nc@freebsd.org>
To: Kevin Bowling <kevin.bowling@kev009.com>
Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()
Message-ID: <9b006e97a64d01d128d81bc09f0891ea@freebsd.org>
In-Reply-To: <CAK7dMtDuJ_4z2Xwej1hpGcXC6LaP5Wwo5ymbA_4-tds22spOgg@mail.gmail.com>
References: <202104261525.13QFPrbg086311@gitrepo.freebsd.org> <CAK7dMtDuJ_4z2Xwej1hpGcXC6LaP5Wwo5ymbA_4-tds22spOgg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-04-26 09:47, Kevin Bowling wrote: > I'm not sure all the context or conversation here but the convention > is to not use bare return values, i.e in style(9) "Values in return > statements should be enclosed in parentheses." and that's what was > asked to be changed on this mailing list. The review: https://reviews.freebsd.org/D29988 I believe I was asked to do this in the review. -Neel > > Can you use and link to Phabricator for your src commits? As much as > possible it is preferable to get it right in one go, for MFCs, > bisection, etc and this kind of churn should be preventable with quick > reviews. Feel free to tag me as a reviewer. Sure, will do next time. > Regards, > Kevin -Neel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9b006e97a64d01d128d81bc09f0891ea>