Date: Mon, 12 Apr 2021 17:15:29 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mark Johnston <markj@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: dfff37765ce4 - main - Rename struct device to struct _device Message-ID: <20210412171529.GA24055@FreeBSD.org> In-Reply-To: <202104121430.13CEUUIq030729@slippy.cwsent.com> References: <202104121336.13CDaI5A029079@gitrepo.freebsd.org> <202104121430.13CEUUIq030729@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 12, 2021 at 07:30:30AM -0700, Cy Schubert wrote: > Mark Johnston writes: > > > > Rename struct device to struct _device > > [...] > > Not that a name matters much but struct _device gives me a sense that > the struct is ancillary. Whereas freebsd_device or fbsd_device is more > descriptive and gives the struct the status it deserves. It should not be needed, AFAIR, as device_t is one of a few properly opaque typedefs for (opaque) struct pointers. Bruce had explained this in detail a couple of times, at least: https://lists.freebsd.org/pipermail/svn-src-head/2011-October/030894.html https://lists.freebsd.org/pipermail/svn-src-head/2016-May/085790.html ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210412171529.GA24055>