Date: Wed, 8 Mar 2017 13:55:14 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe Message-ID: <20170308215514.GQ1044@FreeBSD.org> In-Reply-To: <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> References: <201703071543.v27FhnoL024242@repo.freebsd.org> <20170307221733.GN1044@FreeBSD.org> <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote: A> On 08/03/2017 00:17, Gleb Smirnoff wrote: A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: A> > A> Author: avg A> > A> Date: Tue Mar 7 15:43:49 2017 A> > A> New Revision: 314862 A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862 A> > A> A> > A> Log: A> > A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy A> > A> A> > A> The module uses unnamed structure and union fields and base GCC in A> > A> stable/10 doesn't like it. A> > A> I think that that is a C11 feature, so it is courteous of more modern A> > A> compilers to not complain about it when compiling in C99 mode. A> > A> > There are a lot of code in kernel, that uses anonymous structs and unions. A> > This feature is enabled globally. Why does this module need special treatment? A> A> That's a good question and I don't have a good answer to it. A> All I can say is that a GCC build of GENERIC and modules failed in that fashion A> only for this module (in stable/10). A> Maybe I described the problem incorrectly. Then, a proper explanation is welcome. In head this is fixed properly: https://svnweb.freebsd.org/base?view=revision&revision=278913 Can you please move your fix to stable/10 and revert it in head? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170308215514.GQ1044>