Date: Thu, 11 Dec 2003 19:59:37 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Peter Grehan <grehan@freebsd.org> Cc: obrien@freebsd.org Subject: Re: cvs commit: src/sys/boot/powerpc/loader conf.c Message-ID: <20031211194303.X10479@gamplex.bde.org> In-Reply-To: <3FD7FD29.7050803@freebsd.org> References: <200312100917.hBA9H26R081659@repoman.freebsd.org> <3FD6F0F2.4955B5B2@freebsd.org> <xzpbrqgn11y.fsf@dwp.des.no> <3FD7CD6A.8010909@freebsd.org> <20031211030704.GA53066@dragon.nuxi.com> <3FD7FD29.7050803@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 11 Dec 2003, Peter Grehan wrote: > > If you can wait until the last week of December, I'd be glad to > > do that. > > That'd be great. The diffs are at www.freebsd.org/~grehan/schar.diff, > with maybe the only controversial one being the style for ki_nice > in the kinfo_proc structure. These changes seem to be basically correct and have correct style except for not merging the declarations of most of the new "int ch" variables with the declarations of the other int variables. The fix for kg_nice in proc.h is missing. Only the relatively unimportant declaration of ki_nice in user.h is fixed. The fixes should be easy to test on i386's by compiling with -funsigned-char. What bugs does putting negative niceness in the (unsigned) char variable kg_nice cause? Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031211194303.X10479>