Date: Wed, 29 Oct 2014 03:58:30 +0100 From: Michal Privoznik <mprivozn@redhat.com> To: Conrad Meyer <cse.cem@gmail.com> Cc: libvir-list@redhat.com, "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org> Subject: Re: [libvirt] [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests. Message-ID: <545057D6.1010402@redhat.com> In-Reply-To: <CAG6CVpWSGcHR2jU7zCsm8OP584dR2Pt7WHOV5KyQUy9Lpq%2B8tg@mail.gmail.com> References: <1414094284-29055-1-git-send-email-cse.cem@gmail.com> <1414094284-29055-2-git-send-email-cse.cem@gmail.com> <54503292.9040907@redhat.com> <CAG6CVpWSGcHR2jU7zCsm8OP584dR2Pt7WHOV5KyQUy9Lpq%2B8tg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29.10.2014 02:01, Conrad Meyer wrote: >> I don't think it's safe to pass arbitrary arguments from XML. I find this >> too critical to ACK the patch, buy maybe further discussion can change my >> mind. > > Michal, > > You're reviewing a 4-revision old version of this patch, see v5 for > the most recent set. However, this bit is still present in v5. What is > <bootloader_args> in the XML is for, if not arbitrary arguments? > Oh right. I was getting through a lot of e-mails and I didn't notice you've posted v5. And yes, you're right - <bootloader_args/> is designed for that. Okay then. Let me see how v5 went. Michal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?545057D6.1010402>