Date: Fri, 28 Nov 2025 01:00:50 +0000 From: Joseph Mingrone <jrm@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 6049f1bc2106 - main - git-arc: Fix failure to call arc() function Message-ID: <6928f442.278f4.18def5e9@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by jrm: URL: https://cgit.FreeBSD.org/src/commit/?id=6049f1bc210653b126974961b29d6eb71a6c6709 commit 6049f1bc210653b126974961b29d6eb71a6c6709 Author: Joseph Mingrone <jrm@FreeBSD.org> AuthorDate: 2025-11-27 22:46:43 +0000 Commit: Joseph Mingrone <jrm@FreeBSD.org> CommitDate: 2025-11-28 00:53:56 +0000 git-arc: Fix failure to call arc() function As of b3e53f9fff11, git-arc attempted to call the internal shell function, arc(), using env(1). However, because env(1) does not call shell functions, it actually attempted to run the arc utility. This led to errors: % git arc create -r xxx HEAD env: arc: No such file or directory git-arc: could not create Phabricator diff This change removes the unnecessary use of env(1), so the arc() function is correctly called. Reviewed by: markj Fixes: b3e53f9fff11 ("git-arc: Don't require devel/arcanist") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53972 --- tools/tools/git/git-arc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tools/git/git-arc.sh b/tools/tools/git/git-arc.sh index eef01b75663e..8507d96fda63 100755 --- a/tools/tools/git/git-arc.sh +++ b/tools/tools/git/git-arc.sh @@ -315,7 +315,7 @@ create_one_review() printf "\nSubscribers:\n" >> "$msg" printf "%s\n" "${subscribers}" >> "$msg" - yes | env EDITOR=true \ + yes | EDITOR=true \ arc diff --message-file "$msg" --never-apply-patches --create \ --allow-untracked $BROWSE --head "$commit" "${commit}~" [ $? -eq 0 ] || err "could not create Phabricator diff"help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6928f442.278f4.18def5e9>