Date: Sat, 12 Jun 2010 16:49:14 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: M. Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, rdivacky@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r208964 - in head: . etc/mtree lib share/mk usr.bin Message-ID: <EC0B4984-AF13-4A68-B78A-C48570083482@semihalf.com> In-Reply-To: <20100610.092502.72112000528403516.imp@bsdimp.com> References: <201006091957.o59JvKbu025122@svn.freebsd.org> <20100610.092502.72112000528403516.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2010-06-10, at 17:25, M. Warner Losh wrote:
> In message: <201006091957.o59JvKbu025122@svn.freebsd.org>
> Roman Divacky <rdivacky@freebsd.org> writes:
> : Modified: head/share/mk/bsd.own.mk
> : ==============================================================================
> : --- head/share/mk/bsd.own.mk Wed Jun 9 19:32:20 2010 (r208963)
> : +++ head/share/mk/bsd.own.mk Wed Jun 9 19:57:20 2010 (r208964)
> : @@ -288,6 +288,18 @@ _no_fdt= FDT
> : .endif
> :
> : #
> : +# Default behaviour of MK_CLANG depends on the architecture.
> : +#
> : +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \
> : + ${MACHINE_ARCH} == "powerpc"
> : +_clang_yes=CLANG
> : +_clang_no=
> : +.else
> : +_clang_yes=
> : +_clang_no=CLANG
> : +.endif
>
> We really should *NOT* be encoding architecture stuff like this into
> bsd.own.mk. Sometimes the right thing here is MACHINE_ARCH, and for
> the moment, since clang is not a bootstrap tool, this is correct.
> However, once clang is a bootstrap tool, this will be incorrect
> because during the bootstrapping for cross building TARGET_ARCH is
> what should be tested. We have the same problem with the FTD stuff
> that was recently committed. raj@ and I have been talking about the
> best ways to fix it.
I think I'm going to drop setting WITH_FDT by default for selected arches until the tdbemd arrives, and for this little (I hope :-) while it will just be required for FDT-enabled platforms to specify WITH_FDT explicitly.
Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC0B4984-AF13-4A68-B78A-C48570083482>