Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Dec 2007 20:41:16 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Doug Barton <dougb@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/etc/rc.d ldconfig
Message-ID:  <200712122041.17462.jhb@freebsd.org>
In-Reply-To: <476088C3.9090207@FreeBSD.org>
References:  <200712130051.lBD0p1ZY011259@repoman.freebsd.org> <476088C3.9090207@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 12 December 2007 08:20:03 pm Doug Barton wrote:
> John Baldwin wrote:
> > jhb         2007-12-13 00:51:01 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     etc/rc.d             ldconfig 
> >   Log:
> >   Only pass paths to directories or config files that exist for ldconfig 
for
> >   32-bit binaries.
> >   
> >   MFC after:      3 days
> >   
> >   Revision  Changes    Path
> >   1.19      +8 -2      src/etc/rc.d/ldconfig
> > 
> > 
http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/ldconfig.diff?&r1=1.18&r2=1.19&f=h
> > 
> 
> I'm not saying this is a bad idea, but doesn't ldconfig ignore stuff
> that doesn't exist? As for the test, I think you might want -x instead
> of -r.

It emits a warning on the console and this shuts up that warning.

I used -r to match what we do for the two other places in this script when we 
sanity check the paths to pass to ldconfig.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712122041.17462.jhb>