Date: Thu, 6 Feb 2020 11:30:55 -0500 From: Mark Johnston <markj@freebsd.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356818 - in head/sys/geom: . concat eli gate journal linux_lvm mirror nop part raid raid3 shsec stripe Message-ID: <20200206163055.GB60144@spy> In-Reply-To: <202001170115.00H1FtSu082373@repo.freebsd.org> References: <202001170115.00H1FtSu082373@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 17, 2020 at 01:15:55AM +0000, Warner Losh wrote: > Author: imp > Date: Fri Jan 17 01:15:55 2020 > New Revision: 356818 > URL: https://svnweb.freebsd.org/changeset/base/356818 > > Log: > Pass BIO_SPEEDUP through all the geom layers > > While some geom layers pass unknown commands down, not all do. For the ones that > don't, pass BIO_SPEEDUP down to the providers that constittue the geom, as > applicable. No changes to vinum or virstor because I was unsure how to add this > support, and I'm also unsure how to test these. gvinum doesn't implement > BIO_FLUSH either, so it may just be poorly maintained. gvirstor is for testing > and not supportig BIO_SPEEDUP is fine. > > Reviewed by: chs > Differential Revision: https://reviews.freebsd.org/D23183 Hi Warner, BIO_SPEEDUP triggers an assertion failure in virtblk, as found by syzkaller. I'm not sure how best to handle it - I don't think there's anything the driver can really do with BIO_SPEEDUP, so it could be dropped, but maybe it's unexpected that it's made it to this layer in the first place. http://syzkaller.backtrace.io:8080/file?name=crashes%2f1e84321d4576307b788b7c3e4526facc7d10a46c%2freport0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200206163055.GB60144>