Date: Sat, 1 Nov 2008 22:58:48 GMT From: Peter Wemm <peter@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 152332 for review Message-ID: <200811012258.mA1Mwm4F042984@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=152332 Change 152332 by peter@peter_overcee on 2008/11/01 22:58:20 AARGH!!!! Fix the value of SIG_SETMASK in sigprocmask syscall. (It is 2 on linux, 3 on FreeBSD.) This was duplicated rather than using #includes. This is responsible for the assertion failures on non-trivial code due to signals getting unblocked when they should have remained blocked for the interpreter-driven periodic polling to find them. Affected files ... .. //depot/projects/valgrind/coregrind/m_syswrap/syscall-amd64-freebsd.S#3 edit .. //depot/projects/valgrind/coregrind/m_syswrap/syscall-x86-freebsd.S#6 edit Differences ... ==== //depot/projects/valgrind/coregrind/m_syswrap/syscall-amd64-freebsd.S#3 (text+ko) ==== @@ -71,7 +71,7 @@ */ /* from vki_arch.h */ -#define VKI_SIG_SETMASK 2 +#define VKI_SIG_SETMASK 3 .globl ML_(do_syscall_for_client_WRK) ML_(do_syscall_for_client_WRK): ==== //depot/projects/valgrind/coregrind/m_syswrap/syscall-x86-freebsd.S#6 (text+ko) ==== @@ -84,7 +84,7 @@ */ /* from vki_arch.h */ -#define VKI_SIG_SETMASK 2 +#define VKI_SIG_SETMASK 3 /* QQQ translate syscall abi conventions */ .globl ML_(do_syscall_for_client_WRK)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811012258.mA1Mwm4F042984>