Date: Fri, 07 Feb 2014 23:44:54 +0200 From: Aleksandr Rybalko <ray@ddteam.net> To: Ed Schouten <ed@80386.nl>,Aleksandr Rybalko <ray@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r261585 - head/sys/dev/vt/hw/vga Message-ID: <ff14c458-500d-4c3a-9e06-c3dee375be10@email.android.com> In-Reply-To: <CAJOYFBC9S8FLjJxL%2BEHGiwvszuJG7CN-_d2SbqXUjB7VX%2Byf7Q@mail.gmail.com> References: <201402071239.s17CdwIH007683@svn.freebsd.org> <CAJOYFBAAmcfrob4LsBC2jz6TxfNPd%2Bh6Np_dn7toOgXRZHAiow@mail.gmail.com> <20140207171025.d33b95770f6b0d7d00b4aab3@freebsd.org> <CAJOYFBC9S8FLjJxL%2BEHGiwvszuJG7CN-_d2SbqXUjB7VX%2Byf7Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 лютого 2014 р. 23:27:58 GMT+02:00, Ed Schouten <ed@80386.nl> wrote: >Hi Aleksandr, > >On 7 February 2014 16:10, Aleksandr Rybalko <ray@freebsd.org> wrote: >> On Fri, 7 Feb 2014 15:04:47 +0100 >> Ed Schouten <ed@80386.nl> wrote: >>> On 7 February 2014 13:39, Aleksandr Rybalko <ray@freebsd.org> wrote: >> Also people asking me about advanced features of vt(9), like use >> multiple displays. I'm not sure, but signed coordinates may help with >> some things on that way (or makes more problems :) ). > >But if you were to have multiple displays, you should have separate >coordinate systems per display. It should not be seen as a single >pane. I don't really know yet how that will be implemented. :-) > >>> Furthermore, I think it's a bit weird that vga_bitbltchr() contains >>> explicit bounds checking. What happened there? I remember at one >point >>> in time, we had the nice invariant that vt(9) never attempted to >draw >>> outside of the display resolution. What caused us to give up on >that? >> >> Mouse cursor allowed to partially go out of screen, so we have to >check >> (or use special function for mouse cursor). > >Well, that's a compelling argument. Still, it's a bit weird then that >the bitblt function itself does not take signed coordinates. Would it >make sense to bring that in sync then? Yup, this is good idea to sync them. Will do that a bit later. Thanks a lot Ed! Let me know if you will have something more. WBW ------ Aleksandr Rybalko <ray@ddteam.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ff14c458-500d-4c3a-9e06-c3dee375be10>