Date: Sat, 14 Nov 2020 00:53:07 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Ravi Pokala <rpokala@freebsd.org> Cc: Rebecca Cran <bcran@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve Message-ID: <C86489F8-4811-4BCA-B9E7-B4B37A82C7A5@freebsd.org> In-Reply-To: <328D3129-4682-491B-A28F-D6739E52ABE8@panasas.com> References: <202011131947.0ADJlGbr064616@repo.freebsd.org> <328D3129-4682-491B-A28F-D6739E52ABE8@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 Nov 2020, at 00:47, Ravi Pokala <rpokala@freebsd.org> wrote: >=20 >> +#define FIRMWARE_RELEASE_DATE "11/10/2020" >=20 > Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and = ISO-8601 demand? ;-) Alas that is a "feature" of the specification: String number of the BIOS release date. The date string, if supplied, is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the string is two digits, the year is assumed to be 19yy. NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and later. (SMBIOS Specification version 3.4.0c) It might be worth putting a comment in so people don't accidentally change it to the wrong thing in future though, given it's currently ambiguous otherwise. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C86489F8-4811-4BCA-B9E7-B4B37A82C7A5>