Date: Sun, 16 Jun 2002 14:43:39 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "Greg 'groggy' Lehey" <grog@FreeBSD.org> Cc: Pete Fritchman <petef@absolutbsd.org>, Alexey Zelkin <phantom@ark.cris.net>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/calendar Makefile Message-ID: <20020616142952.H2113-100000@gamplex.bde.org> In-Reply-To: <20020616000418.GE65995@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 16 Jun 2002, Greg 'groggy' Lehey wrote:
> Ah, thanks. So what about this?
>
> .for lang in ${INTER}
> install -d -o ${BINOWN} -g ${BINGRP} -m ${DIRMODE} ${DESTDIR}${SHAREDIR}/calendar/${lang}
> ${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \
> ${.CURDIR}/calendars/${lang}/calendar.* \
> ${DESTDIR}${SHAREDIR}/calendar/${lang}
> .endfor
Style bugs at best :-). Apart from just using install -d, it hard-codes
${INSTALL} and has a line longer than 80 characters mixed with carefully
split lines in old code.
> I know that this doesn't address the question about whether this
> should be done by mtree or not. Normally it would, but I don't
> believe that the 'make install' should fail because it's done in the
> directory.
It's less that useful with out this addressing. The addressing might
involve propagating the attributes set in this file to the mtree
database or vice versa. This would be too complicated for me.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020616142952.H2113-100000>