Date: Wed, 22 Oct 2014 08:02:49 -0600 From: Warner Losh <imp@bsdimp.com> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r273417 - head Message-ID: <6287010D-9C54-4167-9784-84134080A419@bsdimp.com> In-Reply-To: <86iojco2oh.fsf@nine.des.no> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> <86iojco2oh.fsf@nine.des.no>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Oct 22, 2014, at 3:48 AM, Dag-Erling Smørgrav <des@des.no> wrote:
> Warner Losh <imp@bsdimp.com> writes:
>> I’ll fix this. I think we need to have a MK_TESTS_SUPPORT that builds
>> the libatf stuff when yes, and omits it when no, since we don’t want
>> the tests building when we’re building the 4.3 stage.
>
> I agree, bundling everything under MK_TESTS does not make much sense.
> Automake has the same bug ("make check" will both build the tests and
> run them, and while you can rerun the tests without rebuilding them
> ("make recheck"), there is no way to build them without running them.
>
> I would prefer calling this MK_ATF than MK_TESTS_SUPPORT, though. The
> test framework is probably useful on its own.
That would be a nicer name, but then we’d lose the automatic setting when MK_TESTS
is enabled (unless we add another special case, which is the opposite direction that
I want to go in). How strongly do you feel that’s a better name?
Warner
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJUR7kKAAoJEGwc0Sh9sBEAK9MP/A/zrxF7PUIfpQq98M9UM2ky
K/0Vjjc/mOPBNCBirkE2HG+J+QRmjZ5O23+J9E+AWCCz7+ucPVT3T0vanx8pHm4W
x3bTAJvE76W8KKpPQyCQEgN7ZiK/PdNIB9mqWwOqExLzZ7MCUdIDQK7Bi01WnPbs
aMYFEMP9md/cu7HX90TkAhzjn0awK6zOYeHx1fGonTce0WhQvSsPHeUX0IobVwbP
85TuLXOiEKezC1wJn1MhzW6XfplVY2kPNgfQ6oAw0U0pqBghUQpymbFemezScqOG
ELPMUlNLvchyrL8T0rlIpYeuOX9zlCLBsu3jWMkwSNqVBFktl+eD/SwWOOu1Bj8X
xBcH50sD7Me4bITsaUZ9nHcdKpXdThqlGwzfop/b1fuYgBUsXiNUebBtYuL8gQKP
HVL4wCTBy2levCqd0rm0G4WLXq2hsmCEpBASPhkR4K6L1m5mKw2DWAXnWieOnX8S
snXuJ5h3cULEST8fZqbdh6/u23/ka+mFRh4FRIk+5sjjMHQ2IMpdyJC8Yz/D1GEI
795T4bpFm6MIyD0JeZ6eNYS1PMq2Zp/qXoUYGgcA97kiseQLYoUqiOpUKd24AVqX
R1PbhO/QTrkf8J5O763DIH6ABTrdO0Uhhbl8FqZBLW1YA6vHkV3jNTfiJscvM7uV
M6yA9ztaAJXOp1suyvia
=smAw
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6287010D-9C54-4167-9784-84134080A419>