Date: Wed, 01 Jun 2016 09:28:58 -0700 From: John Baldwin <jhb@freebsd.org> To: Julian Elischer <julian@freebsd.org> Cc: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299393 - in head: . share/mk Message-ID: <1635327.lWf6hTW5HF@ralph.baldwin.cx> In-Reply-To: <c625e4d1-b1fe-7388-6f51-18983f5f6fbb@freebsd.org> References: <201605102232.u4AMWNvp000287@repo.freebsd.org> <6335113.N7gIF2Maer@ralph.baldwin.cx> <c625e4d1-b1fe-7388-6f51-18983f5f6fbb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, May 30, 2016 01:21:50 PM Julian Elischer wrote: > On 27/05/2016 2:28 AM, John Baldwin wrote: > > On Wednesday, May 25, 2016 03:27:07 PM Hans Petter Selasky wrote: > >> On 05/11/16 00:32, John Baldwin wrote: > >>> Author: jhb > >>> Date: Tue May 10 22:32:23 2016 > >>> New Revision: 299393 > >>> URL: https://svnweb.freebsd.org/changeset/base/299393 > >>> > >>> Log: > >>> Change the default installation directory for modules to /boot/modules. > >>> > >>> Kernel installs always override KMODDIR when installing modules, so > >>> this default setting is only used for standalone module builds. Many > >>> out-of-tree modules manually override KMODDIR already to avoid placing > >>> modules in /boot/kernel. This now makes that behavior the default. > >>> > >>> Discussed on: arch@ > >>> Reviewed by: imp > >>> Relnotes: yes > >>> > >> Just a small nit: > >> > >> There is a comment in bsd.own.mk which needs updating too: > >> > >>> # > >>> # KMODDIR Base path for loadable kernel modules > >>> # (see kld(4)). [/boot/kernel] > > Oops, thanks. Fixed. > > the comment should also mention it does not cover in-tree modules. Actually, it does. If you cd /sys/modules/foo and run make install it installs to this path. Only buildkernel overrides this explicitly when installing the modules built together with a kernel. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1635327.lWf6hTW5HF>