Date: Fri, 19 Sep 2014 23:42:03 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Will Andrews" <will@firepipe.net>, "John Baldwin" <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "src-committers@FreeBSD.org" <src-committers@freebsd.org> Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <22388302B2EF4C53B49F0541ABDB3198@multiplay.co.uk> References: <201409181655.s8IGtgft042984@svn.freebsd.org><5783417ED470465B9C816FCA02B3690D@multiplay.co.uk><11362806.9nSfhFyLDg@ralph.baldwin.cx> <CADBaqmjTpvXeQUg=gO89xdW-n6afmtFnsFtZAMvs%2B4gXj_tYPw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
----- Original Message -----
From: "Will Andrews" <will@firepipe.net>
To: "John Baldwin" <jhb@freebsd.org>
Cc: "Steven Hartland" <killing@multiplay.co.uk>; "src-committers@FreeBSD.org" <src-committers@freebsd.org>;
<svn-src-all@freebsd.org>; <svn-src-head@freebsd.org>
Sent: Friday, September 19, 2014 6:35 PM
Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
>I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this
> particular implementation of the tunable, so there is a regression
> that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no
> matter what's in loader.conf). I believe it's limited to this
> particular tunable, however, because I tested another SYSCTL_PROC that
> had CTLFLAG_TUN set and it worked.
Given I pointed you in this direction I kinda felt guilty that you where having issues
so had a dig.
It took quite a few printf's and a reboots but I found the cause.
The name of your sysctl is conflicting with the 4th loader which believes
your vfs.zfs.debug_flags is a module _flags setting as it matches the reserved
suffix *_flags as detailed in loader.conf (5).
I think the loader should only consider [a-z0-9_]+_flags as module flags as I can't see
any modules having any other chars expecially not "." in their name; but I've no idea
how to do that in 4th.
So the fix is to rename you sysctl e.g. vfs.zfs.debugflags.
Hope this helps.
Regards
Steve
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22388302B2EF4C53B49F0541ABDB3198>