Date: Thu, 16 Jan 2003 09:53:47 -0800 (PST) From: Nate Lawson <nate@root.org> To: Martin Blapp <mbr@FreeBSD.org> Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/usr.sbin/mountd mountd.c src/usr.sbin/rpc.lockd lockd.c src/usr.sbin/rpc.statd statd.c src/usr.sbin/rpc.yppasswdd yppasswdd_main.c src/usr.sbin/rpcbind rpcb_svc_com.c rpcbind.c src/usr.bin/rpcgen rpc_main.c rpc_svcout.c Message-ID: <Pine.BSF.4.21.0301160949020.46845-100000@root.org> In-Reply-To: <20030116072738.00CC737B423@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 15 Jan 2003, Martin Blapp wrote:
> Modified files:
> usr.sbin/mountd mountd.c
> usr.sbin/rpc.lockd lockd.c
> usr.sbin/rpc.statd statd.c
> usr.sbin/rpc.yppasswdd yppasswdd_main.c
> usr.sbin/rpcbind rpcb_svc_com.c rpcbind.c
> usr.bin/rpcgen rpc_main.c rpc_svcout.c
> Log:
> Implement nonblocking tpc-connections. rpcgen -m does still
> produce backcompatible code.
>
> Reviewed by: rwatson
> Obtained from: NetBSD
> MFC after: 1 day
This looks interesting.
Please use a longer MFC period than 1 day for something which touches
a major library component and many user programs. In particular, changes
like this could use testing:
> - switch (poll_ret = poll(pollfds, nfds, INFTIM)) {
> + switch (poll_ret = poll(pollfds, nfds, 30 * 1000)) {
I'm sure it works fine on NetBSD but there are always subtle interactions.
IMO, a 1 day MFC should only be used for man pages or whitespace changes
or things which should only have a compile-time effect.
-Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0301160949020.46845-100000>