Date: Thu, 24 Apr 2003 19:52:20 -0500 From: "Jacques A. Vidrine" <nectar@FreeBSD.org> To: Juli Mallett <jmallett@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/fsck fsck.c Message-ID: <20030425005220.GB23638@madman.celabo.org> In-Reply-To: <200303030940.h239eWGY061182@repoman.freebsd.org> References: <200303030940.h239eWGY061182@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 03, 2003 at 01:40:32AM -0800, Juli Mallett wrote: > jmallett 2003/03/03 01:40:32 PST > > FreeBSD src repository > > Modified files: > sbin/fsck fsck.c > Log: > Strip out bogus difference from when this came from NetBSD: transliterating > upper-case alphabetical characters to lower-case ones, and spaces to dashes. > The person who added this when bringing the code from NetBSD has no idea why > he added it, and nobody on freebsd-fs came up with any cases where the icky > part (the conversion of spaces to underscores) was needed. The removal of > the upper-case conversion follows an even more obvious logic: it avoids any > sort of namespace issues. People using StUdLy caps for filesystem names > deserve everything they get. Otherwise, Efs and efs might be totally different > things, but would use the same fsck. And we don't want that, right? That > just provokes the sort of foot-shooting this would prevent. > > If you have problems with this, I'll walk you through using sed on your fstab, > cause the only way you could have problems is if you spelled ufs as "UFS". > Most likely, you haven't done that. > > MFC after: 1 month > > Revision Changes Path > 1.13 +1 -17 src/sbin/fsck/fsck.c Hi Juli, Please back this out. If there is no fstab, the vfstype is retrieved from the disklabel. It will likely be `4.2BSD', and fsck will try to find /sbin/fsck_4.2BSD and fail. Look at `FS_BSDFFS' and `fstypenames[]' in sys/disklabel.h to see what I mean. (A failure of this sort was just reported to me by a coworker.) And please don't remove any more code just because you don't know why it is there. K PLZ THX :-) Cheers, -- Jacques A. Vidrine <nectar@celabo.org> http://www.celabo.org/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030425005220.GB23638>