Date: Thu, 14 Nov 2013 16:51:01 -0500 From: George Neville-Neil <gnn@freebsd.org> To: Sergey Kandaurov <pluknet@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258142 - head/sys/net Message-ID: <A2749F6A-4F91-4DC7-A2C4-0F75AE20DB5E@freebsd.org> In-Reply-To: <CAE-mSOKfAgZQMuXJ1mF0vyB6EgRVMQ5CpxNX%2BSh7Q6dHiA=fnQ@mail.gmail.com> References: <201311142007.rAEK7InH068095@svn.freebsd.org> <CAE-mSOKfAgZQMuXJ1mF0vyB6EgRVMQ5CpxNX%2BSh7Q6dHiA=fnQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Nov 14, 2013, at 16:03 , Sergey Kandaurov <pluknet@FreeBSD.org> wrote: > On 15 November 2013 00:07, George V. Neville-Neil <gnn@freebsd.org> wrote: >> Author: gnn >> Date: Thu Nov 14 20:07:17 2013 >> New Revision: 258142 >> URL: http://svnweb.freebsd.org/changeset/base/258142 >> >> Log: >> Shift our OUI correctly. >> >> Pointed out by: emaste >> >> Modified: >> head/sys/net/ieee_oui.h >> >> Modified: head/sys/net/ieee_oui.h >> ============================================================================== >> --- head/sys/net/ieee_oui.h Thu Nov 14 19:53:35 2013 (r258141) >> +++ head/sys/net/ieee_oui.h Thu Nov 14 20:07:17 2013 (r258142) >> @@ -62,5 +62,5 @@ >> */ >> >> /* Allocate 64K to bhyve */ >> -#define OUI_FREEBSD_BHYVE_LOW OUI_FREEBSD + 0x000001 >> -#define OUI_FREEBSD_BHYVE_HIGH OUI_FREEBSD + 0x00ffff >> +#define OUI_FREEBSD_BHYVE_LOW ((OUI_FREEBSD << 3) + 0x000001) >> +#define OUI_FREEBSD_BHYVE_HIGH ((OUI_FREEBSD << 3) + 0x00ffff) > > Shouldn't it be rather shifted with 24 (3 x 8bits)? Correct, and it should really be an | not a +. I’ll commit a fix. Best, George [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlKFRcUACgkQYdh2wUQKM9JB9wCeNC9JszmSKr5mlDGYNWOupN3b IycAoLRYRCigL8MPa3YGAZbsKUv2RFih =Vqip -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A2749F6A-4F91-4DC7-A2C4-0F75AE20DB5E>