Date: Wed, 22 Oct 2014 11:37:32 -0400 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Ian Lepore <ian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r273417 - head Message-ID: <CAJ5_RoA_bz_qT=Oi8K1Z5-Vg-7nOrijM_jXKZwWZoc3%2BSSLL0g@mail.gmail.com> In-Reply-To: <1413992086.12052.548.camel@revolution.hippie.lan> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> <86iojco2oh.fsf@nine.des.no> <6287010D-9C54-4167-9784-84134080A419@bsdimp.com> <86mw8ocftw.fsf@nine.des.no> <CAJ5_RoDci=Y%2BCwFsK4j53xw_nq1r6inyvLQda1pajVjYsHrrJg@mail.gmail.com> <1413992086.12052.548.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 22, 2014 at 11:34 AM, Ian Lepore <ian@freebsd.org> wrote: > On Wed, 2014-10-22 at 11:00 -0400, Benjamin Kaduk wrote: > > On Wed, Oct 22, 2014 at 10:57 AM, Dag-Erling Sm=C3=B8rgrav <des@des.no> > wrote: > > > > > Is _SUPPORT magic? I didn't know. I guess MK_TESTS_SUPPORT is good > > > enough, especially if it's on by default. > > > > > > Even if it is magic, is that really the kind of magic we want to be > keeping > > around? > > > > -Ben > > I didn't really think of it as magic so much as analogous to INVARIANTS > vs INVARIANTS_SUPPORT in kernel config. > I can put INVARIANTS but not INVARIANTS_SUPPORT in my kernel config ... and it gives me a somewhat inscrutable build error. I didn't get the impression that's what's going on with MK_TESTS... -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoA_bz_qT=Oi8K1Z5-Vg-7nOrijM_jXKZwWZoc3%2BSSLL0g>