Date: Sun, 08 Aug 2010 15:36:08 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: olli@fromme.com Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, olli@FreeBSD.org Subject: Re: svn commit: r211023 - head/usr.sbin/syslogd Message-ID: <20100808.153608.1142818667055052395.imp@bsdimp.com> In-Reply-To: <201008082037.o78KbLDt022321@haluter.fromme.com> References: <20100807.205058.260300877050427878.imp@bsdimp.com> <201008082037.o78KbLDt022321@haluter.fromme.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <201008082037.o78KbLDt022321@haluter.fromme.com>
Oliver Fromme <olli@fromme.com> writes:
:
: M. Warner Losh wrote:
: > In message: <201008071620.o77GKDBb091327@svn.freebsd.org>
: > Oliver Fromme <olli@FreeBSD.org> writes:
: > : Author: olli
: > : Date: Sat Aug 7 16:20:12 2010
: > : New Revision: 211023
: > : URL: http://svn.freebsd.org/changeset/base/211023
: > : Modified: head/usr.sbin/syslogd/Makefile
: > : ==============================================================================
: > : --- head/usr.sbin/syslogd/Makefile Sat Aug 7 16:14:40 2010 (r211022)
: > : +++ head/usr.sbin/syslogd/Makefile Sat Aug 7 16:20:12 2010 (r211023)
: > : @@ -12,7 +12,7 @@ SRCS= syslogd.c ttymsg.c
: > : DPADD= ${LIBUTIL}
: > : LDADD= -lutil
: > :
: > : -WARNS?= 3
: > : +WARNS?= 6
: > :
: > : .if ${MK_INET6_SUPPORT} != "no"
: > : CFLAGS+= -DINET6
: >
: > This breaks MIPS, so I've reverted it. Please make sure that all
: > architectures work when bumping up WARNS.
:
: Thanks for fixing it for me.
:
: I did make the universe check, but apparently I did something
: wrong, so I didn't notice the problem. I'm sorry for that.
The casting that syslogd does with struct sockaddrFOO is what triggers
it. I'm not sure how to fix it, so there's about 6 or 8 programs in
the tree that have WARNS lowered to 3 because of it.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100808.153608.1142818667055052395.imp>