Date: Wed, 1 Apr 2015 23:06:54 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r280971 - in head: contrib/ipfilter/tools share/man/man4 sys/contrib/ipfilter/netinet sys/netinet sys/netipsec sys/netpfil/pf Message-ID: <78B754F0-60D9-4E75-84B5-C260094AAFD0@FreeBSD.org> In-Reply-To: <201504012226.t31MQedN044443@svn.freebsd.org> References: <201504012226.t31MQedN044443@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 01 Apr 2015, at 22:26 , Gleb Smirnoff <glebius@FreeBSD.org> wrote: >=20 > Author: glebius > Date: Wed Apr 1 22:26:39 2015 > New Revision: 280971 > URL: https://svnweb.freebsd.org/changeset/base/280971 >=20 > Log: > o Use new function ip_fillid() in all places throughout the kernel, > where we want to create a new IP datagram. > o Add support for RFC6864, which allows to set IP ID for atomic IP > datagrams to any value, to improve performance. The behaviour is > controlled by net.inet.ip.rfc6864 sysctl knob, which is enabled by > default. > o In case if we generate IP ID, use counter(9) to improve = performance. > o Gather all code related to IP ID into ip_id.c. >=20 > Differential Revision: = https://reviews.freebsd.org/D2177 > Reviewed by: adrian, cy, rpaulo > Tested by: Emeric POUPON <emeric.poupon = stormshield.eu> > Sponsored by: Netflix > Sponsored by: Nginx, Inc. > Relnotes: yes >=20 breaks build, e.g. sparc64 generic-nodebug: /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: data = definition has no type or storage class /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: type defaults = to 'int' in declaration of 'SYSINIT' /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: parameter = names (without types) in function declaration /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: data = definition has no type or storage class /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: type defaults = to 'int' in declaration of 'SYSUNINIT' /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: parameter = names (without types) in function declaration /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:269: error: expected ')' = before '(' token /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:282: error: expected =E2=80=98= )' before '(' token i386 GENERIC has more info =E2=80=A6 07:8: error: type specifier missing, defaults to 'int' = [-Werror,-Wimplicit-int] static MALLOC_DEFINE(M_IPID, "ipid", "randomized ip id state"); ^ /scratch/tmp/bz/head.svn/sys/sys/malloc.h:137:2: note: expanded from = macro 'MALLOC_DEFINE' SYSINIT(type##_init, SI_SUB_KMEM, SI_ORDER_THIRD, malloc_init, = \ ^ /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107:8: error: a parameter = list without types is only allowed in a function definition /scratch/tmp/bz/head.svn/sys/sys/malloc.h:137:10: note: expanded from = macro 'MALLOC_DEFINE' SYSINIT(type##_init, SI_SUB_KMEM, SI_ORDER_THIRD, malloc_init, = \ ^ <scratch space>:235:1: note: expanded from here M_IPID_init ^ > Modified: > head/contrib/ipfilter/tools/ipftest.c > head/share/man/man4/inet.4 > head/sys/contrib/ipfilter/netinet/fil.c > head/sys/contrib/ipfilter/netinet/ip_fil.h > head/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c > head/sys/contrib/ipfilter/netinet/ip_nat.c > head/sys/netinet/ip_carp.c > head/sys/netinet/ip_gre.c > head/sys/netinet/ip_id.c > head/sys/netinet/ip_input.c > head/sys/netinet/ip_mroute.c > head/sys/netinet/ip_output.c > head/sys/netinet/ip_var.h > head/sys/netinet/raw_ip.c > head/sys/netinet/sctp_output.c > head/sys/netipsec/xform_ipip.c > head/sys/netpfil/pf/if_pfsync.c > head/sys/netpfil/pf/pf_norm.c =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?78B754F0-60D9-4E75-84B5-C260094AAFD0>