Date: Sat, 1 Apr 2017 15:44:28 +0800 From: Sepherosa Ziehau <sepherosa@gmail.com> To: "Somayajulu, David" <David.Somayajulu@cavium.com> Cc: hiren panchasara <hiren@strugglingcoder.info>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, David C Somayajulu <davidcs@freebsd.org> Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe Message-ID: <CAMOc5cxt2YjpsFqARiVY0w7bWT=GDrvddFwdk1H7kdD=qdPebg@mail.gmail.com> In-Reply-To: <BY2PR07MB1474F0541FB69A91B5AC9FA0EE340@BY2PR07MB1474.namprd07.prod.outlook.com> References: <201703302243.v2UMhX2s011405@repo.freebsd.org> <20170330230227.GH1016@strugglingcoder.info> <BY2PR07MB14744C383EA86B3EA1F3927CEE340@BY2PR07MB1474.namprd07.prod.outlook.com> <20170330231158.GI1016@strugglingcoder.info> <BY2PR07MB1474F0541FB69A91B5AC9FA0EE340@BY2PR07MB1474.namprd07.prod.outlook.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maybe it's time to add an IFCAP for HWLRO. On Fri, Mar 31, 2017 at 7:39 AM, Somayajulu, David <David.Somayajulu@cavium.com> wrote: >>> > I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled. >>> Will do. Sorry about that. > Minor correction. Please note that the driver provides the ability to choose between SoftwareLRO and HW LRO, when LRO is enabled - it is HW LRO by default. If LRO is turned off via ifconfig, neither Software nor HW LRO is enabled. > > Cheers > David S. > > -----Original Message----- > From: hiren panchasara [mailto:hiren@strugglingcoder.info] > Sent: Thursday, March 30, 2017 4:12 PM > To: Somayajulu, David <David.Somayajulu@cavium.com> > Cc: David C Somayajulu <davidcs@FreeBSD.org>; src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freebsd.org > Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe > > On 03/30/17 at 11:07P, Somayajulu, David wrote: >> Hi Hiren, >> > I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled. >> Will do. Sorry about that. > > Thanks! >> >> > Do you know of a case where one would want to disable h/w lro and enable s/w lro? I guess where you want to free up nic and make cpu do more work? >> I was under the impression as well, that s/w lro is moot, if h/w lro was available, till one costumer asked for it. Not sure what the use case is. > > I thought this idea (like gro in linux) was popular when lro in h/w was considered buggy and couldn't correctly do batching (i.e. hide useful flags). Not sure if that's still the case. > > cheers, > Hiren > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5cxt2YjpsFqARiVY0w7bWT=GDrvddFwdk1H7kdD=qdPebg>