Date: Thu, 16 Dec 1999 14:02:11 -0800 (PST) From: Kirk McKusick <mckusick@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/contrib/softupdates ffs_softdep.c Message-ID: <199912162202.OAA39541@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
mckusick 1999/12/16 14:02:10 PST
Modified files:
sys/contrib/softupdates ffs_softdep.c
Log:
The function request_cleanup() had a tsleep() with PCATCH. It is
quite dangerous, since the process may hold locks at the point,
and if it is stopped in that tsleep the machine may hang. Because
the sleep is so short, the PCATCH is not required here, so it has
been removed. For the future, the FreeBSD team needs to decide
whether it is still reasonable to stop a process in tsleep, as that
may affect any other code that uses PCATCH while holding kernel locks.
Submitted by: Dmitrij Tejblum <tejblum@arc.hq.cti.ru>
Reviewed by: Kirk McKusick <mckusick@mckusick.com>
Revision Changes Path
1.40 +2 -2 src/sys/contrib/softupdates/ffs_softdep.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199912162202.OAA39541>