Date: Sat, 30 Mar 2002 00:18:29 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Mark Murray <markm@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass Makefile chpass.c chpass.h edit.c field.c pw_copy.c pw_yp.c table.c util.c Message-ID: <20020330001829.B67334@dragon.nuxi.com> In-Reply-To: <200203241021.g2OALMU84291@freefall.freebsd.org>; from markm@FreeBSD.org on Sun, Mar 24, 2002 at 02:21:22AM -0800 References: <200203241021.g2OALMU84291@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 24, 2002 at 02:21:22AM -0800, Mark Murray wrote: > markm 2002/03/24 02:21:22 PST > > Modified files: > usr.bin/chpass Makefile chpass.c chpass.h edit.c field.c > pw_copy.c pw_yp.c table.c util.c > Log: > Fix warns, ANSIfy, use __FBSDID(), sort headers. > > Revision Changes Path > 1.25 +1 -2 src/usr.bin/chpass/Makefile > http://cvsweb.freebsd.org/src/usr.bin/chpass/Makefile.diff?r1=1.24&r2=1.25 > 1.21 +9 -8 src/usr.bin/chpass/chpass.c > http://cvsweb.freebsd.org/src/usr.bin/chpass/chpass.c.diff?r1=1.20&r2=1.21 This is most likely a bad fix: +char localhost[] = "localhost"; did you try to make `yp_server' a "const char *" and then fix the yp functions so they take a const parameters for those arguments they do not modify. I fixed this type of change you made last time, if you want to see ways of doing it. The change you made just covers over the issue and allows you to do incomplete [lint] fixes. If you are going to lint the entire code base, I'd prefer the fixes were high quality, even when involved; vs. just covering over things lint complains about. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020330001829.B67334>