Date: Wed, 10 Feb 2016 22:27:42 -0800 From: Adrian Chadd <adrian.chadd@gmail.com> To: Mori Hiroki <yamori813@yahoo.co.jp> Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: Re: about if_arge.c Message-ID: <CAJ-Vmon-95o%2Bdpk9yUQaDUUjJKp9USYc_u5wPQfSVJ0-ffUuqw@mail.gmail.com> In-Reply-To: <316967.63047.qm@web101710.mail.ssk.yahoo.co.jp> References: <316967.63047.qm@web101710.mail.ssk.yahoo.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
heh, good catch! I'll go fix it. -a On 10 February 2016 at 20:41, Mori Hiroki <yamori813@yahoo.co.jp> wrote: > I make AR2315 ethercode. I refer if_arge.c and I have idea. > > Current code is here. > > if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > arge_fixup_rx(m); > > m->m_pkthdr.rcvif = ifp; > /* Skip 4 bytes of CRC */ > m->m_pkthdr.len = m->m_len = packet_len - ETHER_CRC_LEN; > > > I think better set m_len before arge_fixup_rx(). > This is only copy packet length at arge_fixup_rx(). > > /* Skip 4 bytes of CRC */ > m->m_pkthdr.len = m->m_len = packet_len - ETHER_CRC_LEN; if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > arge_fixup_rx(m); > > m->m_pkthdr.rcvif = ifp; > > And > > if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > m_adj(m, sizeof(uint64_t)); > > I think not need uint64_t(8byte) only tcp header 2 byte(ETHER_ALIGN) shift. > > if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > m_adj(m, sizeof(uint32_t)); > > Regards. > > Hiroki Mori > > _______________________________________________ > freebsd-mips@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmon-95o%2Bdpk9yUQaDUUjJKp9USYc_u5wPQfSVJ0-ffUuqw>