Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Jan 2003 05:36:24 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Nate Lawson <nate@root.org>
Cc:        Hidetoshi Shimokawa <simokawa@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c   fwohcivar.h
Message-ID:  <20030117052637.I3675-100000@gamplex.bde.org>
In-Reply-To: <Pine.BSF.4.21.0301161007080.46845-100000@root.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 16 Jan 2003, Nate Lawson wrote:

> On Thu, 16 Jan 2003, Hidetoshi Shimokawa wrote:
> >   Modified files:
> >     sys/dev/firewire     firewire.c fwdev.c fwohci.c fwohcivar.h
> >...
>
> Some comments.
>
> > -		contigfree((void *)(uintptr_t)sc->fc.sid_buf,
> > -					OHCI_SIDSIZE, M_DEVBUF);
> > +		free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF);
>
> Unnecessary casts (there are others).

Er, these casts seem to be necessary to break warnings from -Wcast-qual.
sid_buf has type "volatile u_int32_t *".

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030117052637.I3675-100000>