Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 May 2023 23:55:58 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Hans Petter Selasky <hselasky@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.
Message-ID:  <7482D20A-86B1-434B-A817-AECEF6D5828B@freebsd.org>
In-Reply-To: <6ed6216b-d237-fbe0-e2b8-960c53a53562@freebsd.org>
References:  <202305211621.34LGLsup059861@gitrepo.freebsd.org> <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> <21c9532e-4ca7-a7fe-1ff6-07a94cbad6ab@freebsd.org> <3066464F-E4C6-4B84-ADFF-E578AFAFE622@freebsd.org> <e802dfc0-0a16-add1-cf5d-a8811b3bd3e6@freebsd.org> <26465813-3B51-4E52-9E9D-F93A0F2AF6BD@freebsd.org> <ffb3f6ea-ef74-ebe3-884d-da567defd2e6@freebsd.org> <2BF2F7CF-82E6-4D98-800D-C35D7C29E948@freebsd.org> <ac11ff8e-eeb9-a7e6-28d3-da5c9fad6567@freebsd.org> <8f46512a-f086-6da0-2fdd-3ffc89f4dfdd@freebsd.org> <1787C08C-AD82-48EC-92E2-49360B1AB8B0@freebsd.org> <6ed6216b-d237-fbe0-e2b8-960c53a53562@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 21 May 2023, at 23:51, Hans Petter Selasky <hselasky@freebsd.org> =
wrote:
>=20
> On 5/22/23 00:32, Jessica Clarke wrote:
>> Once again I will remind you that the FreeBSD tree is not somewhere =
for you to play around with experiments. Changes should be properly =
justified.
>=20
> Hi Jess,
>=20
> This is FreeBSD-current / main and my change is perfectly fine as =
such. Sorry.

Just because it=E2=80=99s not stable/* or releng/* doesn=E2=80=99t mean =
you can=E2=80=99t do whatever you want.

> It is not my problem why GIT has to use cryptographic hashes, so that =
commit messages cannot be changed without forced pushing.

I don=E2=80=99t even want to start up that debate again.

> The justification for this change should be clear from our e-mail =
exchange.

Your attempt at one is. A justification that I wholeheartedly disagree =
with, and that you yourself have undermined by stating multiple ways in =
which you would make it unnecessary.

For the fifth time: revert this patch. Today. Not at some point in the =
future of your choice when you feel like it.

Jess




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7482D20A-86B1-434B-A817-AECEF6D5828B>