Date: Sun, 14 Jan 2018 02:02:29 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: Justin Hibbits <jhibbits@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r327906 - in head/sys: conf powerpc/mpc85xx Message-ID: <20180113180229.GA96844@ns.kevlo.org> In-Reply-To: <3bd7260a-4bac-2718-9836-15bb25cbc793@FreeBSD.org> References: <201801130136.w0D1abhS054355@repo.freebsd.org> <40f39e41-f051-0758-fe15-55c1dab64c9c@FreeBSD.org> <CAHSQbTDgMEFFr46wA0yrhswcikVTcQ-fc3KFBFem172v%2BqCOqw@mail.gmail.com> <3bd7260a-4bac-2718-9836-15bb25cbc793@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 13, 2018 at 10:38:43AM -0500, Pedro Giffuni wrote: > > ... > > > On 13/01/2018 10:33, Justin Hibbits wrote: > > > > > > On Jan 13, 2018 09:04, "Pedro Giffuni" <pfg@freebsd.org > > <mailto:pfg@freebsd.org>> wrote: > > > > > > > > On 12/01/2018 20:36, Justin Hibbits wrote: > > > > Author: jhibbits > > Date: Sat Jan 13 01:36:37 2018 > > New Revision: 327906 > > URL: https://svnweb.freebsd.org/changeset/base/327906 > > <https://svnweb.freebsd.org/changeset/base/327906>; > > ... > > > > > > Added: head/sys/powerpc/mpc85xx/mpc85xx_cache.c > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly > > added) > > +++ head/sys/powerpc/mpc85xx/mpc85xx_cache.c Sat Jan 13 > > 01:36:37 2018 (r327906) > > @@ -0,0 +1,129 @@ > > +/*- > > + * Copyright (c) 2018 Justin Hibbits > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or > > without > > + * modification, are permitted provided that the following > > conditions > > + * are met: > > + * 1. Redistributions of source code must retain the above > > copyright > > + * notice, this list of conditions and the following > > disclaimer. > > + * 2. Redistributions in binary form must reproduce the above > > copyright > > + * notice, this list of conditions and the following > > disclaimer in the > > + * documentation and/or other materials provided with the > > distribution. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS > > ``AS IS'' AND > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > LIMITED TO, THE > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > > PARTICULAR PURPOSE > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR > > CONTRIBUTORS BE LIABLE > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, > > OR CONSEQUENTIAL > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > > SUBSTITUTE GOODS > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > > INTERRUPTION) > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > > CONTRACT, STRICT > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > > ARISING IN ANY WAY > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > > POSSIBILITY OF > > + * SUCH DAMAGE. > > + * > > + * $FreeBSD$ > > + */ > > + > > > > > > Can we please add SPDX ID tags, specially on new code? > > I had them added to the guidelines: > > > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/pref-license.html > > <https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/pref-license.html>; > > > > It is just not fun for me anymore to go hunting for untagged files > > and they keep appearing ;). > > > > Pedro. > > > > > > D'oh, sorry. I had used an existing boilerplate template I have lying > > around that didn't have the SPDX tags. I'll update and fix this. > > > It's OK, no hurry. The diff below adds SPDX tag to the example copyright. Index: share/examples/etc/bsd-style-copyright =================================================================== --- share/examples/etc/bsd-style-copyright (revision 327932) +++ share/examples/etc/bsd-style-copyright (working copy) @@ -1,4 +1,6 @@ /*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * * Copyright (c) [year] [your name] * All rights reserved. *
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180113180229.GA96844>