Date: Sun, 16 Sep 2012 08:09:20 -0700 From: mdf@FreeBSD.org To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Chris Rees <crees@freebsd.org>, Andrew Turner <andrew@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r240549 - head/sys/arm/tegra Message-ID: <CAMBSHm_6YAQeLAgXm4mu5mT76T1irfmQdWx=PVfOx%2B5ihLnksQ@mail.gmail.com> In-Reply-To: <20120916095355.GA83285@FreeBSD.org> References: <201209160755.q8G7tnMH036332@svn.freebsd.org> <20120916092818.GA81952@FreeBSD.org> <CADLo83-5zQBdf3ndBXO4qbkXJgaFPxGfE86LSDGqJ4g3k_4gkw@mail.gmail.com> <20120916095355.GA83285@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 16, 2012 at 2:53 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote: >> On 16 September 2012 10:28, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> > I thought preferred and more style(9) compliant way to code [empty >> > endless loop] is: >> > >> > for (;;) >> > continue; >> >> Actually: >> >> for (;;) >> ; > > Explicit "continue" is supposed to tell reviewer that original author did > not make a typo, but indeed knew what he was doing. Lonely semicolon is too > ambiguous in this case. The semicolon being on its own line is not ambiguous, and is good style everywhere. A semicolon on the same line as a while or for is a red flag that it may be unintentional. Cheers, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMBSHm_6YAQeLAgXm4mu5mT76T1irfmQdWx=PVfOx%2B5ihLnksQ>