Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Mar 2017 10:38:32 -0800
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        Ngie Cooper <ngie@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r314563 - head/usr.sbin/syslogd
Message-ID:  <3E8487D0-9BF5-47D4-9E77-A2F62224223E@gmail.com>
In-Reply-To: <201703021807.v22I7Jeg016057@repo.freebsd.org>
References:  <201703021807.v22I7Jeg016057@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Mar 2, 2017, at 10:07, Ngie Cooper <ngie@FreeBSD.org> wrote:
>=20
> Author: ngie
> Date: Thu Mar  2 18:07:19 2017
> New Revision: 314563
> URL: https://svnweb.freebsd.org/changeset/base/314563
>=20
> Log:
>  Wordsmith syslogd(8)
>=20
>  - Clarify -p/-S options by using appropriate subject-verb modifiers
>    (verb and modifiers suggested that the subject should have been
>    singular).
>  - Simplify/correct -a description:
>  -- Be more terse when describing IPv4 (the "usual dotted notation"
>     isn't necessarily well understood by the reader). Being blunt and
>     saying "IPv4 address" with an optional netmask is.
>  -- prefixlen is the appropriate terminology for IPv6.
>  -- mask/prefixlen is optional, not required (as noted later on in the
>     section).
>  -- split up IPv4/IPv6 use so to clarify both forms.
>  -- Fix wordiness when describing the optional "service" specifier.
>  - -T: Use "cannot" instead of "can't" [*].
>=20
>  Bump .Dd for the changes.
>=20
>  MFC after:    1 month
>  Reported by:    igor [*]
>  Reviewed by:    hrs
>  Sponsored by:    Dell EMC Isilon
>  Differential Revision:    https://reviews.freebsd.org/D9855
>=20
> Modified:
>  head/usr.sbin/syslogd/syslogd.8
>=20
> Modified: head/usr.sbin/syslogd/syslogd.8
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- head/usr.sbin/syslogd/syslogd.8    Thu Mar  2 17:35:13 2017    (r31456=
2)
> +++ head/usr.sbin/syslogd/syslogd.8    Thu Mar  2 18:07:19 2017    (r31456=
3)
> @@ -28,7 +28,7 @@
> .\"     @(#)syslogd.8    8.1 (Berkeley) 6/6/93
> .\" $FreeBSD$
> .\"
> -.Dd December 21, 2016
> +.Dd March 2, 2017
> .Dt SYSLOGD 8
> .Os
> .Sh NAME
> @@ -102,21 +102,23 @@ options may be specified.
> The
> .Ar allowed_peer
> option may be any of the following:
> -.Bl -tag -width "ipaddr/masklen[:service]XX"
> +.Bl -tag -width "ipaddr[/prefixlen][:service]XX"
> .It Xo
> .Sm off
> .Ar ipaddr
> -.No / Ar masklen
> +.Op / Ar masklen
> +.Op \&: Ar service
> +.Pp
> +.Ar ipaddr
> +.Op / Ar prefixlen
> .Op \&: Ar service
> .Sm on
> .Xc
> Accept datagrams from
> +.Ar ipaddr ,
> .Ar ipaddr
> -(in the usual dotted quad notation) with
> -.Ar masklen
> -bits being taken into account when doing the address comparison.
> -.Ar ipaddr
> -can be also IPv6 address by enclosing the address with
> +can be specified as an IPv4 address or as an IPv6
> +address enclosed with
> .Ql \&[
> and
> .Ql \&] .
> @@ -129,7 +131,7 @@ A
> .Ar service
> of
> .Ql \&*
> -allows packets being sent from any UDP port.
> +allows packets to be sent from any UDP port.

Rereading my change, I think this part might be incorrect. I will go back an=
d review the source code and correct if necessary.

Thanks,
-Ngie=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E8487D0-9BF5-47D4-9E77-A2F62224223E>