Date: Thu, 27 Mar 2003 17:43:45 -0500 From: Bosko Milekic <bmilekic@unixdaemons.com> To: Mike Silbersack <silby@silby.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c Message-ID: <20030327224345.GA66106@unixdaemons.com> In-Reply-To: <20030327163012.F748@odysseus.silby.com> References: <200303260452.h2Q4quap015364@www.ambrisko.com> <20030326114030.U2075@odysseus.silby.com> <20030326183351.GJ57674@elvis.mu.org> <20030326130903.G2075@odysseus.silby.com> <20030327013224.P7674@odysseus.silby.com> <20030327164402.GA15454@unixdaemons.com> <20030327165800.GK57674@elvis.mu.org> <20030327171501.GA18549@unixdaemons.com> <20030327163012.F748@odysseus.silby.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 27, 2003 at 04:31:02PM -0600, Mike Silbersack wrote: > > I'll give this a shot when I get time to work on the patch next. If a > similar change to m_dup_pkthdr works fine, do you want me to go ahead and > commit it? Yes. Just make sure to test and let me know if/when you do, because I have some other improvements which rely on this change in my tree. > Thanks, > > Mike "Silby" Silbersack > > On Thu, 27 Mar 2003, Bosko Milekic wrote: > > > > > See attached. Similar logic may be applied to m_dup_pkthdr(). > > > > On Thu, Mar 27, 2003 at 05:58:00PM +0100, Maxime Henrion wrote: > > > Bosko Milekic wrote: > > > > > > > > Can you please still use m_gethdr() or m_getcl() to do the allocations > > > > in the defragment function? Similarly, for > MCLBYTES, use m_getm(). > > > > Don't roll your own. > > > > > > Please see my reply to Mike for the first version of his patch. He > > > couldn't do this because m_dup_pkthdr() has a KASSERT() that makes it > > > panic if we have a cluster attached to the mbuf. > > > > > > Cheers, > > > Maxime > > > > > > > -- > > Bosko Milekic > > bmilekic@unixdaemons.com > > bmilekic@FreeBSD.org > > > > > -- Bosko Milekic bmilekic@unixdaemons.com bmilekic@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030327224345.GA66106>