Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Apr 2009 20:32:37 +0300
From:      Maxim Ignatenko <gelraen.ua@gmail.com>
To:        bug-followup@freebsd.org, gdef@wp.pl
Cc:        freebsd-current@freebsd.org
Subject:   Re: kern/132715: [lagg] [panic] Panic when creating vlan's on lagg  interface
Message-ID:  <ac42db050904281032y7155332crc96b090893326d65@mail.gmail.com>
In-Reply-To: <ac42db050904200846t776579feq6a0f62abe4f88f06@mail.gmail.com>
References:  <ac42db050904200846t776579feq6a0f62abe4f88f06@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--0016363b88a65766ad0468a0d95b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

em(4), igb(4) and ixgbe(4) registers EVENTHANDLER vlan_config, but
don't do any checks that this event generated by adding vlan on top of
their devices.

I'm don't completely sure what the right way to fix this issue, but
attached patch works for me.

--0016363b88a65766ad0468a0d95b
Content-Type: text/plain; charset=US-ASCII; name="patch.txt"
Content-Disposition: attachment; filename="patch.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fu2vk99w0

SW5kZXg6IGUxMDAwL2lmX2lnYi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGUxMDAwL2lmX2lnYi5jCShyZXZp
c2lvbiAxOTEyMDEpCisrKyBlMTAwMC9pZl9pZ2IuYwkod29ya2luZyBjb3B5KQpAQCAtNDI3NCw2
ICs0Mjc0LDggQEAKIAlzdHJ1Y3QgYWRhcHRlcgkqYWRhcHRlciA9IGlmcC0+aWZfc29mdGM7CiAJ
dTMyCQljdHJsLCByY3RsLCBpbmRleCwgdmZ0YTsKIAorCWlmIChzdHJjbXAoImlnYiIsaWZwLT5p
Zl9kbmFtZSkpIHJldHVybjsKKwogCWN0cmwgPSBFMTAwMF9SRUFEX1JFRygmYWRhcHRlci0+aHcs
IEUxMDAwX0NUUkwpOwogCWN0cmwgfD0gRTEwMDBfQ1RSTF9WTUU7CiAJRTEwMDBfV1JJVEVfUkVH
KCZhZGFwdGVyLT5odywgRTEwMDBfQ1RSTCwgY3RybCk7CkBAIC00MzA2LDYgKzQzMDgsOCBAQAog
CXN0cnVjdCBhZGFwdGVyCSphZGFwdGVyID0gaWZwLT5pZl9zb2Z0YzsKIAl1MzIJCWluZGV4LCB2
ZnRhOwogCisJaWYgKHN0cmNtcCgiaWdiIixpZnAtPmlmX2RuYW1lKSkgcmV0dXJuOworCiAJLyog
UmVtb3ZlIGVudHJ5IGluIHRoZSBoYXJkd2FyZSBmaWx0ZXIgdGFibGUgKi8KIAlpbmRleCA9ICgo
dnRhZyA+PiA1KSAmIDB4N0YpOwogCXZmdGEgPSBFMTAwMF9SRUFEX1JFR19BUlJBWSgmYWRhcHRl
ci0+aHcsIEUxMDAwX1ZGVEEsIGluZGV4KTsKSW5kZXg6IGUxMDAwL2lmX2VtLmMKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gZTEwMDAvaWZfZW0uYwkocmV2aXNpb24gMTkxMjAxKQorKysgZTEwMDAvaWZfZW0uYwko
d29ya2luZyBjb3B5KQpAQCAtNDc3MSw2ICs0NzcxLDggQEAKIAlzdHJ1Y3QgYWRhcHRlcgkqYWRh
cHRlciA9IGlmcC0+aWZfc29mdGM7CiAJdTMyCQljdHJsLCByY3RsLCBpbmRleCwgdmZ0YTsKIAor
CWlmIChzdHJjbXAoImVtIixpZnAtPmlmX2RuYW1lKSkgcmV0dXJuOworCiAJY3RybCA9IEUxMDAw
X1JFQURfUkVHKCZhZGFwdGVyLT5odywgRTEwMDBfQ1RSTCk7CiAJY3RybCB8PSBFMTAwMF9DVFJM
X1ZNRTsKIAlFMTAwMF9XUklURV9SRUcoJmFkYXB0ZXItPmh3LCBFMTAwMF9DVFJMLCBjdHJsKTsK
QEAgLTQ4MDMsNiArNDgwNSw4IEBACiAJc3RydWN0IGFkYXB0ZXIJKmFkYXB0ZXIgPSBpZnAtPmlm
X3NvZnRjOwogCXUzMgkJaW5kZXgsIHZmdGE7CiAKKwlpZiAoc3RyY21wKCJlbSIsaWZwLT5pZl9k
bmFtZSkpIHJldHVybjsKKwogCS8qIFJlbW92ZSBlbnRyeSBpbiB0aGUgaGFyZHdhcmUgZmlsdGVy
IHRhYmxlICovCiAJaW5kZXggPSAoKHZ0YWcgPj4gNSkgJiAweDdGKTsKIAl2ZnRhID0gRTEwMDBf
UkVBRF9SRUdfQVJSQVkoJmFkYXB0ZXItPmh3LCBFMTAwMF9WRlRBLCBpbmRleCk7CkluZGV4OiBp
eGdiZS9peGdiZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGl4Z2JlL2l4Z2JlLmMJKHJldmlzaW9uIDE5MTIw
MSkKKysrIGl4Z2JlL2l4Z2JlLmMJKHdvcmtpbmcgY29weSkKQEAgLTQwMzEsNiArNDAzMSw4IEBA
CiAJc3RydWN0IGFkYXB0ZXIJKmFkYXB0ZXIgPSBpZnAtPmlmX3NvZnRjOwogCXUzMgkJY3RybCwg
cmN0bCwgaW5kZXgsIHZmdGE7CiAKKwlpZiAoc3RyY21wKCJpeGdiZSIsaWZwLT5pZl9kbmFtZSkp
IHJldHVybjsKKwogCWN0cmwgPSBJWEdCRV9SRUFEX1JFRygmYWRhcHRlci0+aHcsIElYR0JFX1ZM
TkNUUkwpOwogCWN0cmwgfD0gSVhHQkVfVkxOQ1RSTF9WTUUgfCBJWEdCRV9WTE5DVFJMX1ZGRTsK
IAljdHJsICY9IH5JWEdCRV9WTE5DVFJMX0NGSUVOOwpAQCAtNDA1MCw2ICs0MDUyLDggQEAKIAlz
dHJ1Y3QgYWRhcHRlcgkqYWRhcHRlciA9IGlmcC0+aWZfc29mdGM7CiAJdTMyCQlpbmRleCwgdmZ0
YTsKIAorCWlmIChzdHJjbXAoIml4Z2JlIixpZnAtPmlmX2RuYW1lKSkgcmV0dXJuOworCiAJLyog
UmVtb3ZlIGVudHJ5IGluIHRoZSBoYXJkd2FyZSBmaWx0ZXIgdGFibGUgKi8KIAlpeGdiZV9zZXRf
dmZ0YSgmYWRhcHRlci0+aHcsIHZ0YWcsIDAsIEZBTFNFKTsKIAo=
--0016363b88a65766ad0468a0d95b--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac42db050904281032y7155332crc96b090893326d65>