Date: Sun, 26 Dec 1999 20:28:09 +0800 From: Peter Wemm <peter@netplex.com.au> To: "Daniel C. Sobral" <dcs@newsguy.com> Cc: Marcel Moolenaar <marcel@scc.nl>, Bruce Evans <bde@zeta.org.au>, Dag-Erling Smorgrav <des@flood.ping.uio.no>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <19991226122809.26BD01CA0@overcee.netplex.com.au> In-Reply-To: Message from "Daniel C. Sobral" <dcs@newsguy.com> of "Sun, 26 Dec 1999 21:08:03 %2B0900." <38660523.74C8B37@newsguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"Daniel C. Sobral" wrote:
> Peter Wemm wrote:
> >
> > > That is not true. Just try making a file without -C containing a
> > > "comment" and then fortune'ing it.
> >
> > No problem, RELENG_2_2's strfile and fortune, *with* the ignore-comments pa
tch
> > but without -C:
>
> [example failing to show the difference in a fortune *containing* a
> comment skipped]
>
> > -C is just a build inconvenience to make %% parsing optional. We have
> > enough options already without adding them for things that don't make sense
> > to be an option.
>
> -C is an option setting a flag in the dat file telling fortune to ignore
> a specific type of line. Having it unconditional will make us
> incompatible with other fortunes out there.
But this is *our* internal utility for making a fortune.dat for *our*
fortune(1). %% is nonsense to other fortunes.. Requiring -C makes us more
incompatable than recognizing the comment unconditionally - it means we don't
recognize our own files by default with standard options.
> > ie: it still works. Even if it didn't, we don't need -C at 'make world'
> > time because strfile does nothing special with the %% lines, and a new
> > fortune(1) is installed at exactly the same time as the new datfiles.
>
> -C makes something special with the files created by strfile. Setting a
> flag.
>
> Well, whatever. I think making it unconditional is an error, but I won't
> make a bike shed out of it.
I disagree. It is an error to make something difficult for no reason.
Cheers,
-Peter
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991226122809.26BD01CA0>