Date: Mon, 9 Jan 2012 08:15:44 -0500 From: John Baldwin <jhb@freebsd.org> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: svn-src-head@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r229800 - head/sys/conf Message-ID: <201201090815.44495.jhb@freebsd.org> In-Reply-To: <20120108104330.GC1674@garage.freebsd.pl> References: <201201080055.q080tMlJ063808@svn.freebsd.org> <20120108104330.GC1674@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: > On Sun, Jan 08, 2012 at 12:55:22AM +0000, Adrian Chadd wrote: > > Author: adrian > > Date: Sun Jan 8 00:55:22 2012 > > New Revision: 229800 > > URL: http://svn.freebsd.org/changeset/base/229800 > > > > Log: > > Make these two files conditionally build on UFS_ACL, as it doesn't > > seem to be used elsewhere. > > > > Since UFS_ACL is enabled by default for GENERIC kernels, this shouldn't > > break anything - but please beat me to fix things if it does. > > If someone is actually using GENERIC kernel. This change will break all > my system next time I upgrade. Adding UFS_ACL option to the kernel > config to make ZFS kernel module to work doesn't sound very intuitive. > > I understand what you are trying to accomplish, but we really need to > find better way to do this. Until then, could you back it out? Why not make 'options ZFS' work? Then you can have subr_acl_nfs.c depend on ZFS as well. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201090815.44495.jhb>