Date: Sun, 16 Feb 2014 04:02:32 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r261916 - head/sys/dev/xen/console Message-ID: <20140216035823.I2978@besplex.bde.org> In-Reply-To: <201402151237.s1FCbRnh000507@svn.freebsd.org> References: <201402151237.s1FCbRnh000507@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Feb 2014, Dimitry Andric wrote:
> Log:
> In sys/dev/xen/console/console.c, #if 0 an unused static function.
>
> MFC after: 3 days
>
> Modified:
> head/sys/dev/xen/console/console.c
>
> Modified: head/sys/dev/xen/console/console.c
> ==============================================================================
> --- head/sys/dev/xen/console/console.c Sat Feb 15 12:25:01 2014 (r261915)
> +++ head/sys/dev/xen/console/console.c Sat Feb 15 12:37:26 2014 (r261916)
> @@ -356,6 +356,7 @@ xcclose(struct tty *tp)
> xen_console_up = 0;
> }
>
> +#if 0
> static inline int
> __xencons_put_char(int ch)
> {
> @@ -365,6 +366,7 @@ __xencons_put_char(int ch)
> wbuf[WBUF_MASK(wp++)] = _ch;
> return 1;
> }
> +#endif
>
> static void
Why? There are hundreds if not thousands of static inline functions in
headers, and most of these functions are not always used, so there would
be [hundreds if not thousands] * [number of #includes] compiler warnings
if compilers warned about things like this. They could handle include
files specially, but shouldn't.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140216035823.I2978>