Date: Sat, 6 Oct 2001 12:16:54 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ia64/include cpufunc.h Message-ID: <20011006121654.B68233@kayak.xcllnt.net> In-Reply-To: <20011006224619.X1107-100000@delplex.bde.org> References: <200110060931.f969ViC77564@freefall.freebsd.org> <20011006224619.X1107-100000@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 06, 2001 at 10:57:48PM +1000, Bruce Evans wrote:
> On Sat, 6 Oct 2001, Marcel Moolenaar wrote:
>
> > marcel 2001/10/06 02:31:44 PDT
> >
> > Modified files:
> > sys/ia64/include cpufunc.h
> > Log:
> > o Change ia64_memory_address to explicitly take a u_int64_t
> > o Add memcpy_fromio, memcpy_io, memcpy_toio, memset_io,
> > memsetw and memsetw_io. I'm not sure this is the right
> > place for it, though.
>
> Certainly not. As the comment near the beginning says says, cpufunc.h
> is "to provide access to special ${MACHINE_ARCH} instructions". It should
> not contain anything that can be written in C, including anything that
> can be written in C by combining primitives written in inline asm.
I thought so. What is the right place, then. It seems that bus_memio.h
is a good match, but that file is empty for all ports and thus is
making me nervous. The other logical place is bus.h. On alpha the
functions are there, but that's mostly because of the implementation.
--
Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011006121654.B68233>