Date: Mon, 13 Sep 2010 18:32:49 +0000 (UTC) From: Weongyo Jeong <weongyo@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r212571 - user/weongyo/usb/sys/dev/usb/controller Message-ID: <201009131832.o8DIWnHV023940@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: weongyo Date: Mon Sep 13 18:32:49 2010 New Revision: 212571 URL: http://svn.freebsd.org/changeset/base/212571 Log: Adds a XXX comment not sure that devclass_find(9) requires Giant holding. Just looking the source code it looks it doesn't require it though it has a `devclasses' traversal loop. Modified: user/weongyo/usb/sys/dev/usb/controller/usb_controller.c Modified: user/weongyo/usb/sys/dev/usb/controller/usb_controller.c ============================================================================== --- user/weongyo/usb/sys/dev/usb/controller/usb_controller.c Mon Sep 13 18:26:34 2010 (r212570) +++ user/weongyo/usb/sys/dev/usb/controller/usb_controller.c Mon Sep 13 18:32:49 2010 (r212571) @@ -394,6 +394,7 @@ usb_attach_sub(device_t dev, struct usb_ { const char *pname = device_get_nameunit(dev); + /* XXX devclass_find(9) needs Giant? */ GIANT_REQUIRED; if (usb_devclass_ptr == NULL) usb_devclass_ptr = devclass_find("usbus");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009131832.o8DIWnHV023940>