Date: Sun, 8 Feb 2026 12:55:21 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Enji Cooper <ngie@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org> Subject: Re: git: 70aab985c300 - stable/15 - heimdal: Pass the correct pointer to free in an error case Message-ID: <1485E40C-2752-4207-972A-E56FD5C8E270@gmail.com> In-Reply-To: <11d5cb2d-7460-4bd9-a33c-e52343f30d1d@FreeBSD.org> References: <6982480e.3097b.628edb67@gitrepo.freebsd.org> <11d5cb2d-7460-4bd9-a33c-e52343f30d1d@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Feb 6, 2026, at 6:41 AM, John Baldwin <jhb@freebsd.org> wrote: > > On 2/3/26 14:10, Enji Cooper wrote: >> The branch stable/15 has been updated by ngie: >> URL: https://cgit.FreeBSD.org/src/commit/?id=70aab985c30092483b5b32cdd3750570ec3d9364 >> commit 70aab985c30092483b5b32cdd3750570ec3d9364 >> Author: John Baldwin <jhb@FreeBSD.org> >> AuthorDate: 2026-01-31 17:00:44 +0000 >> Commit: Enji Cooper <ngie@FreeBSD.org> >> CommitDate: 2026-02-03 19:09:55 +0000 >> heimdal: Pass the correct pointer to free in an error case >> This fixes a warning reported by GCC 14 on stable/14: >> crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object] >> 241 | free(hist_keys); >> | ^~~~~~~~~~~~~~~ >> crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc' >> 234 | ext = calloc(1, sizeof (*ext)); >> | ^~~~~~~~~~~~~~~~~~~~~~~~ >> Reviewed by: rmacklem, cy >> Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option") >> Differential Revision: https://reviews.freebsd.org/D54932 >> (cherry picked from commit b26a7af438f36dcde86f39a681123cc2140affb2) > > Why so eager to MFC all the heimdal fixes before the normal time? They aren't even compiled > on stable/15 by default? These were at least 3 days later, but I think the last one I > committed you merged the next day which seemed a bit odd. Sorry — I jumped the gun looking at the date after I merged the change :/. I was trying to get rid of the build error emails and your change made sense. -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmI+DkACgkQGpE5DjPs NJjmzQ//SOkowHV35bzbUmejmVX24xoFyO9flgcdLFSTsiBuEpB1nvGWlRipHzk+ yJH2C4AwytaeSGvY9FyHuHzbVuV7zq4Pcd+BEI6WwZGYidD855Z2+AfYfu05VAv9 +ciskuBVjKI2AYSv1F6oecc7NVmdxdGFL+KzMbOxWJF2aB2ERD6yVEj0/xO6FwPP mRs67X6ipDsVMidd3qY8M5G5dLfNPklflUpxA4FR9gAkVGbsvL9G22R+KH4x4G6u oOtVyswTNlU1llxHdavHi5m1wkOa0J7mJzsVhDq6icGLKwcq/QzJ/bUka1/flNZo wBpvEY74S+Zg2G4L/MmS3XrrmH7zbsLG2olURPLnp88C6lHNjBM5L3/8QfVXMMNV gcM4QKWjXhPttWj3QiEpiqvrEyquYy0DlTQWYrGaYZd9tCxG8GOVUJFR8KnQQ7Kv am5BFeoyhJ2mR/je+kyL/1tDV6IhSiYsSgnIjyZ16v0da0dHdEF4O04BSCNL8BaR WR9cdawKLIEjSooawzJGq3E0wiZPh6iWlk9tCEPMAFRGpcUmZBjV9uzUgm5lgYMV jw1Bwr+lm0hDGpoicvvQF2/UZqcpcryf7UxhH54GClhQY8LkHu5QBDdpAYMpESRx S+PC4gHc6IlTCY7bL5CSVtX0PonQ7uzowZ7h7TrZp+Ji7F3Q+C8= =Q8aq -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1485E40C-2752-4207-972A-E56FD5C8E270>