Date: Wed, 23 May 2018 06:48:50 -0700 From: Eitan Adler <eadler@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334078 - head/sbin/devd Message-ID: <CAF6rxgkQZrU3sgxO8TEBb2%2BcZ3bxc75OkiMGvzUr0Sgj4BKq1w@mail.gmail.com> In-Reply-To: <CANCZdfoKvBo2XWo%2BARzyJmvDAYYxkAH=jd02W3ga-fX0PKtLYA@mail.gmail.com> References: <201805230739.w4N7d5Z1062496@repo.freebsd.org> <CANCZdfoKvBo2XWo%2BARzyJmvDAYYxkAH=jd02W3ga-fX0PKtLYA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23 May 2018 at 06:35, Warner Losh <imp@bsdimp.com> wrote: > > > On Wed, May 23, 2018 at 1:39 AM, Eitan Adler <eadler@freebsd.org> wrote: >> >> Author: eadler >> Date: Wed May 23 07:39:05 2018 >> New Revision: 334078 >> URL: https://svnweb.freebsd.org/changeset/base/334078 >> >> Log: >> devd: compile at WARNS=6 >> >> Verified with "make universe TARGETS='amd64 arm arm64 i386 sparc64'" >> >> Modified: >> head/sbin/devd/Makefile >> head/sbin/devd/devd.cc >> head/sbin/devd/token.l >> > ... >> >> Modified: head/sbin/devd/token.l >> >> ============================================================================== >> --- head/sbin/devd/token.l Wed May 23 07:39:02 2018 (r334077) >> +++ head/sbin/devd/token.l Wed May 23 07:39:05 2018 (r334078) >> @@ -38,6 +38,7 @@ >> #include "devd.h" >> #include "y.tab.h" >> >> +extern int lineno; >> int lineno = 1; >> >> static void > > > This is completely bogus. Never ever ever just put extern in the line > before to avoid the warning. That's wrong 100% of the time. You're right. thanks for the reminder. See r334095 -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkQZrU3sgxO8TEBb2%2BcZ3bxc75OkiMGvzUr0Sgj4BKq1w>