Date: Fri, 5 Sep 2025 14:43:36 -0600 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 3ed0cdf7de79 - main - Update vmimage.subr Message-ID: <CANCZdfre_3C4JHsS6qaDxbFgH25zwGDRRK4Zo2L8VkxAsguuSQ@mail.gmail.com> In-Reply-To: <CACE4D75-E639-493E-81D5-755FA5728A48@freebsd.org> References: <202509051842.585IgIXp096270@gitrepo.freebsd.org> <CACE4D75-E639-493E-81D5-755FA5728A48@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000099eef063e13e57b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 5, 2025, 1:40=E2=80=AFPM Jessica Clarke <jrtc27@freebsd.org> wr= ote: > On 5 Sep 2025, at 19:42, Warner Losh <imp@freebsd.org> wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D3ed0cdf7de79fc0f50f57e75cdb9ae1= 78ab0e74c > > > > commit 3ed0cdf7de79fc0f50f57e75cdb9ae178ab0e74c > > Author: Unicorn9x <unicorn9x@yahoo.com.vn> > > AuthorDate: 2025-09-01 11:30:48 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2025-09-05 18:42:21 +0000 > > > > Update vmimage.subr > > > > This "noatime" tweak, reduced the OPNsense constant 50kb - 80kb disk > writes that wear down the SSD / NVME. > > > > Signed-off-by: Unicorn9x > > Reviewed by: imp > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1834 > > --- > > release/tools/vmimage.subr | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr > > index 156987e33457..20ffe3b2dac7 100644 > > --- a/release/tools/vmimage.subr > > +++ b/release/tools/vmimage.subr > > @@ -82,7 +82,7 @@ vm_install_base() { > > echo '# Custom /etc/fstab for FreeBSD VM images' \ > > > ${DESTDIR}/etc/fstab > > if [ "${VMFS}" !=3D zfs ]; then > > - echo "/dev/${ROOTLABEL}/rootfs / ${VMFS} rw 1 1"= \ > > + echo "/dev/${ROOTLABEL}/rootfs / ${VMFS} rw,noatime 1 > 1" \ > > Do we really want to be disabling atime for every UFS VM image we > produce? With ZFS we can do that because /var/mail is separate, but > AFAIK there is no separate /var/mail in the UFS images? > I think we do. /var/mail is used by a relatively small group of users. People that need the mail reader features of /var/mail can enable atime. It's the lesser evil. Warner Jessica > > > >> ${DESTDIR}/etc/fstab > > fi > > if [ -z "${NOSWAP}" ]; then > > --000000000000099eef063e13e57b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote gmail_quote_contai= ner"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Sep 5, 2025, 1:40=E2=80= =AFPM Jessica Clarke <<a href=3D"mailto:jrtc27@freebsd.org">jrtc27@freeb= sd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m= argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 5 Sep 2025= , at 19:42, Warner Losh <<a href=3D"mailto:imp@freebsd.org" target=3D"_b= lank" rel=3D"noreferrer">imp@freebsd.org</a>> wrote:<br> > <br> > The branch main has been updated by imp:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D3ed0cdf7de79= fc0f50f57e75cdb9ae178ab0e74c" rel=3D"noreferrer noreferrer" target=3D"_blan= k">https://cgit.FreeBSD.org/src/commit/?id=3D3ed0cdf7de79fc0f50f57e75cdb9ae= 178ab0e74c</a><br> > <br> > commit 3ed0cdf7de79fc0f50f57e75cdb9ae178ab0e74c<br> > Author:=C2=A0 =C2=A0 =C2=A0Unicorn9x <<a href=3D"mailto:unicorn9x@y= ahoo.com.vn" target=3D"_blank" rel=3D"noreferrer">unicorn9x@yahoo.com.vn</a= >><br> > AuthorDate: 2025-09-01 11:30:48 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2025-09-05 18:42:21 +0000<br> > <br> >=C2=A0 =C2=A0 Update vmimage.subr<br> > <br> >=C2=A0 =C2=A0 This "noatime" tweak, reduced the OPNsense cons= tant 50kb - 80kb disk writes that wear down the SSD / NVME.<br> > <br> >=C2=A0 =C2=A0 Signed-off-by: Unicorn9x<br> >=C2=A0 =C2=A0 Reviewed by: imp<br> >=C2=A0 =C2=A0 Pull Request: <a href=3D"https://github.com/freebsd/freeb= sd-src/pull/1834" rel=3D"noreferrer noreferrer" target=3D"_blank">https://g= ithub.com/freebsd/freebsd-src/pull/1834</a><br> > ---<br> > release/tools/vmimage.subr | 2 +-<br> > 1 file changed, 1 insertion(+), 1 deletion(-)<br> > <br> > diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr<b= r> > index 156987e33457..20ffe3b2dac7 100644<br> > --- a/release/tools/vmimage.subr<br> > +++ b/release/tools/vmimage.subr<br> > @@ -82,7 +82,7 @@ vm_install_base() {<br> > echo '# Custom /etc/fstab for FreeBSD VM images' \<br> > > ${DESTDIR}/etc/fstab<br> > if [ "${VMFS}" !=3D zfs ]; then<br> > - echo "/dev/${ROOTLABEL}/rootfs=C2=A0 =C2=A0/=C2=A0 =C2=A0 =C2= =A0 =C2=A0${VMFS}=C2=A0 =C2=A0rw=C2=A0 =C2=A0 =C2=A0 1=C2=A0 =C2=A0 =C2=A0 = =C2=A01" \<br> > + echo "/dev/${ROOTLABEL}/rootfs=C2=A0 =C2=A0/=C2=A0 =C2=A0 =C2= =A0 =C2=A0${VMFS}=C2=A0 =C2=A0rw,noatime=C2=A0 =C2=A0 =C2=A0 1=C2=A0 =C2=A0= =C2=A0 =C2=A01" \<br> <br> Do we really want to be disabling atime for every UFS VM image we<br> produce? With ZFS we can do that because /var/mail is separate, but<br> AFAIK there is no separate /var/mail in the UFS images?<br></blockquote></d= iv></div><div dir=3D"auto"><br></div><div dir=3D"auto">I think we do. /var/= mail is used by a relatively small group of users. People that need the mai= l reader features of /var/mail can enable atime. It's the lesser evil.<= /div><div dir=3D"auto"><br></div><div dir=3D"auto">Warner</div><div dir=3D"= auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quote gmail_quote_con= tainer"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border= -left:1px #ccc solid;padding-left:1ex"> Jessica<br> <br> > >> ${DESTDIR}/etc/fstab<br> > fi<br> > if [ -z "${NOSWAP}" ]; then<br> <br> </blockquote></div></div></div> --000000000000099eef063e13e57b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfre_3C4JHsS6qaDxbFgH25zwGDRRK4Zo2L8VkxAsguuSQ>