Date: Fri, 20 Jan 2012 12:32:56 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: eadler@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs Message-ID: <20120120.123256.1432718473132856309.hrs@allbsd.org> In-Reply-To: <201201200138.q0K1cSou016739@svn.freebsd.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Fri_Jan_20_12_32_56_2012_697)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eitan Adler <eadler@FreeBSD.org> wrote in <201201200138.q0K1cSou016739@svn.freebsd.org>: ea> Author: eadler ea> Date: Fri Jan 20 01:38:28 2012 ea> New Revision: 230354 ea> URL: http://svn.freebsd.org/changeset/base/230354 ea> ea> Log: ea> Fix a variety of warnings when compiling with gcc46 ea> ea> Approved by: dim, cperciva (mentor, blanket for pre-mentorship already-approved commits) ea> MFC after: 3 days ea> ea> Modified: ea> head/usr.sbin/makefs/cd9660.c Removing the dot handling part and leaving a comment in lines 1106-1117 make people confused. In addition to that, I personally don't think this should be removed because our cd9660.c is still based on NetBSD's one in any way---bugfixes on our side have been reported to the upstream and we will import useful changes from there if any. Although the current dot handling is useless, keeping the difference between the two small still has a meaning. -- Hiroki ----Security_Multipart(Fri_Jan_20_12_32_56_2012_697)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk8Y4GgACgkQTyzT2CeTzy17TwCeNf8nCaYUTJ7ouN2v4wkXuJTb P88An3ZRYyFsDUmkRgNXUm74QwB7CN5i =D+Nd -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Jan_20_12_32_56_2012_697)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120120.123256.1432718473132856309.hrs>