Date: Sat, 15 Jan 2000 23:55:57 -0700 From: Wes Peters <wes@softweyr.com> To: Jason Evans <jasone@canonware.com> Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_sysent.c sys_generic.c syscalls.c syscalls.master uipc_socket.c uipc_socket2.c vfs_aio.c src/sys/sys aio.h socketvar.h syscall-hide.h syscall.h syscall.mk sysproto.h Message-ID: <38816B7D.AA4A3BD6@softweyr.com> References: <200001140253.SAA53905@freefall.freebsd.org> <Pine.BSF.4.10.10001150101530.6969-100000@alphplex.bde.org> <20000114105513.O302@sturm.canonware.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jason Evans wrote:
>
> On Sat, Jan 15, 2000 at 01:14:09AM +1100, Bruce Evans wrote:
> >
> > Don't mix style fixes with new functionality. It makes the diffs hard to
> > read, and hides the new bugs. This change is a particularly good bad
> > example. It reformats lots of old code. The diff (-c1) is 25% larger
> > than the original file.
>
> Okay, that makes sense. So the next time this comes up, should I check in
> the style changes before or after the functionality changes?
Before, if you're fixing the file so you can actually read it. If you can
fix the file without fixing the style first, you should probably just leave
it alone.
--
"Where am I, and what am I doing in this handbasket?"
Wes Peters Softweyr LLC
wes@softweyr.com http://softweyr.com/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?38816B7D.AA4A3BD6>