Date: Wed, 05 Sep 2007 15:35:21 -0600 From: Scott Long <scottl@samsco.org> To: Jack Vogel <jfvogel@gmail.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Andre Oppermann <andre@freebsd.org>, John Baldwin <jhb@yahoo-inc.com> Subject: Re: Thoughts on vlan filter Message-ID: <46DF2119.6030909@samsco.org> In-Reply-To: <2a41acea0709051352n583b4724o359faaf29a1479d8@mail.gmail.com> References: <2a41acea0709051352n583b4724o359faaf29a1479d8@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jack Vogel wrote: > I had an idea, I was debugging a problem on my new 10G driver a week back, > and found I had the hardware vlan filter enabled by accident, this led me to > wonder about supporting this hardware feature in the driver... > > I have done some experimentation, and find that when the vlan device is > configured, ultimately the SETMULTI ioctl will happen in my driver, this > means I could add code that checks the trunk, finds there is a vlan and > then sets the tag into the filter. > > Any interest, or thoughts ya or nay about my doing this? > > Cheers, > > Jack Overloading the SETMULTI ioctl is probably a bad idea for anything more than a proof-of-concept. From a cleanliness point of view, making the software vlan module aware of this as a hardware offload capability and able to control it via new ioctls sounds more reasonable. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46DF2119.6030909>